Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(influxd): refactor run command to use cli.Program to respect config file #18606

Merged
merged 1 commit into from
Jun 18, 2020
Merged

feat(influxd): refactor run command to use cli.Program to respect config file #18606

merged 1 commit into from
Jun 18, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented Jun 18, 2020 •
edited
Loading

example config:

# config.yaml file in same dir as running daemon
http-bind-address: ":8888"
log-level: debug

logs from startup:

2020-06-18T17:45:59.482500Z	info	Listening	{"log_id": "0NU8Rsnl000", "transport": "http", "addr": ":8888", "port": 8888}

@jsteenb2 jsteenb2 force-pushed the feat/influxd_a_program branch from 108abb9 to 58b7203 Compare June 18, 2020 18:02
@jsteenb2 jsteenb2 requested a review from rawkode June 18, 2020 18:02
@jsteenb2 jsteenb2 force-pushed the feat/influxd_a_program branch from 58b7203 to 5f0a7f5 Compare June 18, 2020 18:10
@jsteenb2 jsteenb2 mentioned this pull request Jun 18, 2020
Closed
@jsteenb2 jsteenb2 force-pushed the feat/influxd_a_program branch from 5f0a7f5 to e040bb1 Compare June 18, 2020 18:22
stuartcarnie
stuartcarnie approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@stuartcarnie stuartcarnie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements!

cmd/influxd/launcher/launcher.go Outdated
Comment on lines 129 to 140
cmd.Long = `
Start up the daemon configured with flags/env vars/config file.

The order of precedence for config options are as follows (1 highest, 3 lowest):
1. flags
2. env vars
3. config file

A config file can be provided via the INFLUXD_CONFIG_FILE env var. If a file is
not provided via an env var, influxd will look in the current directory for a
config.yaml file. If one does not exist, then it will continue unchanged.
`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🖤

@jsteenb2 jsteenb2 force-pushed the feat/influxd_a_program branch from e040bb1 to 4e4c509 Compare June 18, 2020 18:46
sanderson
sanderson approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@sanderson sanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@jsteenb2 jsteenb2 force-pushed the feat/influxd_a_program branch 2 times, most recently from 8ece0fd to bb386d3 Compare June 18, 2020 22:12
@jsteenb2 jsteenb2 force-pushed the feat/influxd_a_program branch from bb386d3 to 54e3551 Compare June 18, 2020 22:17
@jsteenb2 jsteenb2 merged commit 84723e1 into master Jun 18, 2020
@jsteenb2 jsteenb2 deleted the feat/influxd_a_program branch June 18, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitirabassi gitirabassi gitirabassi approved these changes

@sanderson sanderson sanderson approved these changes

@stuartcarnie stuartcarnie stuartcarnie approved these changes

@russorat russorat Awaiting requested review from russorat

@bthesorceror bthesorceror Awaiting requested review from bthesorceror

@rawkode rawkode Awaiting requested review from rawkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jsteenb2 @stuartcarnie @sanderson @gitirabassi