feat(pkger): add ability to export by stack #18322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
requested review from
imogenkinsman,
hoorayimhelping and
bthesorceror
and removed request for
a team
jsteenb2
force-pushed
the
18271/pkger_export_by_stack
branch
2 times, most recently
from
495753d to
f978845
Compare
jsteenb2
force-pushed
the
18271/pkger_export_by_stack
branch
2 times, most recently
from
8f4af33 to
be930a4
Compare
this ability exports all resources associated with a stack by the same metadata.name fields as the original application had done it. This can be used as a means to snapshot the current state of the stack. This can be used for source control or other means. closes: #18271
jsteenb2
force-pushed
the
18271/pkger_export_by_stack
branch
2 times, most recently
from
128293b to
8026c22
Compare
jsteenb2
force-pushed
the
18271/pkger_export_by_stack
branch
from
8026c22 to
cd2bbb1
Compare
hoorayimhelping
approved these changes
Jun 2, 2020
| continue | ||
| } | ||
| if err != nil { | ||
| return nil, ierrors.Wrap(err, fmt.Sprintf("failed to find bucket[%s]", res.ID.String())) |
There was a problem hiding this comment.
so this failure message will say:
failed to find bucket[12345876]
or is [%s] some special notation?
There was a problem hiding this comment.
you nailed it. The error message isn't great. I want to go through this service and update the error messages as part of our templates work. For some reason that use case feels like a good time to fixup error messaging... they platform errors we return could dramatically improve across teh platform, we can start with pkger here to try and touch that up 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this ability exports all resources associated with a stack by the same
metadata.name fields as the original application had done it. This can
be used as a means to snapshot the current state of the stack. This can
be used for source control or other means.
closes: #18271
Acceptance Criteria
influx pkg export stack $STACK_ID