Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pkger): add the ability to remove a stack and all its associated resources #17934

Merged
merged 1 commit into from
May 1, 2020
Merged

feat(pkger): add the ability to remove a stack and all its associated resources #17934

merged 1 commit into from
May 1, 2020

Conversation

jsteenb2
Copy link
Contributor

@jsteenb2 jsteenb2 commented May 1, 2020 •
edited
Loading

closes: #17554

@jsteenb2 jsteenb2 requested a review from a team as a code owner May 1, 2020 21:41
@jsteenb2 jsteenb2 requested review from bthesorceror and hoorayimhelping and removed request for a team May 1, 2020 21:41
@jsteenb2 jsteenb2 force-pushed the 17554/remove_stacks branch from 11764e3 to fb682b9 Compare May 1, 2020 21:49
@jsteenb2 jsteenb2 requested a review from a team as a code owner May 1, 2020 21:49
@jsteenb2 jsteenb2 removed the request for review from a team May 1, 2020 21:49
@jsteenb2 jsteenb2 force-pushed the 17554/remove_stacks branch from fb682b9 to 7400b5c Compare May 1, 2020 21:55
hoorayimhelping
hoorayimhelping approved these changes May 1, 2020
View reviewed changes
Copy link
Contributor

@hoorayimhelping hoorayimhelping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question about idempotent-ness (idempotency??)

pkger/http_server.go
}
userID := auth.GetUserID()

err = s.svc.DeleteStack(r.Context(), struct{ OrgID, UserID, StackID influxdb.ID }{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not good enough with go to trace this all the way through, but is this an idempotent operation? will

http DELETE /stacks/1337
http DELETE /stacks/1337

return 204s both times?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh shoot, good call. I didn't write a test for that 🤦

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to answer yoru question, yes it should

@jsteenb2 jsteenb2 force-pushed the 17554/remove_stacks branch 2 times, most recently from 7ccf71b to d3ee21a Compare May 1, 2020 22:33
@jsteenb2 jsteenb2 force-pushed the 17554/remove_stacks branch from d3ee21a to 4796d28 Compare May 1, 2020 22:41
@jsteenb2 jsteenb2 merged commit 95ad3c6 into master May 1, 2020
@jsteenb2 jsteenb2 deleted the 17554/remove_stacks branch May 1, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoorayimhelping hoorayimhelping hoorayimhelping approved these changes

@bthesorceror bthesorceror Awaiting requested review from bthesorceror

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ability to remove stack and all its resources
2 participants
@jsteenb2 @hoorayimhelping