fix(ui): fixed yield bug that was caused by race condition #17208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asalem1
commented
Mar 11, 2020
| @@ -131,8 +131,11 @@ export const executeQueries = (dashboardID?: string) => async ( | |||
| dispatch(setQueryResults(RemoteDataState.Loading, [], null)) | |||
|
|
|||
| await dispatch(refreshTimeMachineVariableValues(dashboardID)) | |||
There was a problem hiding this comment.
this updates the state. So when we we were using state beforehand, the state we had referenced was changed here, but those changes weren't reflected on the state variable
TCL735
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/influxdata/idpe/issues/6240
Problem
Race condition was leading to a bug where user was receiving an error due to an undefined variable
Solution
Replaced the
statewithgetStateto get the most up-to-date version of the state, thereby resolving the race condition error