fix(cmd/influx): ui change for secret #16961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelwang
force-pushed
the
cli_secret_ui
branch
2 times, most recently
from
779a58f to
0a15ff9
Compare
jsteenb2
reviewed
Feb 27, 2020
jsteenb2
approved these changes
Feb 27, 2020
kelwang
force-pushed
the
cli_secret_ui
branch
from
0a15ff9 to
48490cd
Compare
andig
reviewed
Feb 28, 2020
| @@ -51,6 +52,7 @@ func (b *cmdSecretBuilder) cmdUpdate() *cobra.Command { | |||
| cmd := b.newCmd("update", b.cmdUpdateRunEFn) | |||
| cmd.Short = "Update secret" | |||
| cmd.Flags().StringVarP(&b.key, "key", "k", "", "The secret key (required)") | |||
| cmd.Flags().StringVarP(&b.value, "value", "v", "", "Optional secret value for scripting convenience, using this might exposed the secret to your local history") | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16475
removes the confirmation of secret input, add an optional parameter for secret value