fix(http): improve error handling and response to api consumer for org service #16716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
16498/better_http_err_messages
branch
from
f8634a6 to
9812d6b
Compare
jsteenb2
changed the title
jsteenb2
force-pushed
the
16498/better_http_err_messages
branch
3 times, most recently
from
a6814d1 to
c82f693
Compare
jsteenb2
force-pushed
the
16498/better_http_err_messages
branch
from
c82f693 to
26b9167
Compare
jsteenb2
commented
Feb 4, 2020
|
|
||
| func decodePostOrgRequest(ctx context.Context, r *http.Request) (*postOrgRequest, error) { |
There was a problem hiding this comment.
this PR axes a bunch of unneccesary indirection, reduce the jumping around and make it easier to follow within the handler itself.
jsteenb2
force-pushed
the
16498/better_http_err_messages
branch
from
26b9167 to
6924ab8
Compare
bthesorceror
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16498
add a reusable api type for decoding and responding to http requests. Improves error handling.
Work is broken up into 2 commits, first one for creating the API decoder/responder, and the 2nd for using it within the org service. The new API type normalizes handling of decoding issues and failed write issues amongst. It is also very extensible, more we can do with it than what meets the eye.