feat: Add ability to group in Query Builder #16226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoorayimhelping
force-pushed
the
bs_query_builder_grouping
branch
from
03c6ed1 to
50fcaf7
Compare
hoorayimhelping
changed the title
hoorayimhelping
force-pushed
the
bs_query_builder_grouping
branch
7 times, most recently
from
b8c26a0 to
e46a170
Compare
hoorayimhelping
requested review from
121watts,
zoesteinkamp,
asalem1,
drdelambre,
ebb-tide and
goller
121watts
approved these changes
Dec 17, 2019
| /> | ||
| ) | ||
| } | ||
|
|
There was a problem hiding this comment.
This could probably be its own component.
There was a problem hiding this comment.
@121watts it could, but I don't think it adds a ton of value. Once this feature flag goes away, the tag selector will have a BuilderCard.DropdownHeader header until we change the interaction, and the BuilderCard.Header will be applied to other parts of the query builder (like the aggregate functions window)
| draftState.queryBuilder.tags.splice(index, 1) | ||
| draftQuery.builderConfig.tags.splice(index, 1) | ||
| draftState.queryBuilder.tags.splice(index, 1) | ||
| } |
There was a problem hiding this comment.
A reducer test for this added logic would be 👍
hoorayimhelping
force-pushed
the
bs_query_builder_grouping
branch
13 times, most recently
from
fe3a44d to
d13c0bd
Compare
hoorayimhelping
force-pushed
the
bs_query_builder_grouping
branch
13 times, most recently
from
c0ed96c to
b4924ad
Compare
hoorayimhelping
force-pushed
the
bs_query_builder_grouping
branch
3 times, most recently
from
b91d01e to
0e7e82b
Compare
hoorayimhelping
force-pushed
the
bs_query_builder_grouping
branch
from
0e7e82b to
5c7c36d
Compare
|
I just installed the beta and I don't see this functionality anything specific I need to do ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15984
Adds grouping to query builder