Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): sync note editor text and preview scrolling #13311

Merged
merged 1 commit into from
Apr 10, 2019
Merged

feat(ui): sync note editor text and preview scrolling #13311

merged 1 commit into from
Apr 10, 2019

Conversation

ischolten
Copy link
Contributor

@ischolten ischolten commented Apr 10, 2019 •
edited
Loading

Closes #12350

Briefly describe your proposed changes:

notes_sync_scroll_small

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergeable
  • Tests pass
  • http/swagger.yml updated (if modified Go structs or API)
  • Sign CLA (if not already signed)

@ischolten ischolten force-pushed the feat/sync-note-scrolling branch from 4406a7b to 7c0d4f8 Compare April 10, 2019 23:44
Palakp41
Palakp41 approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@Palakp41 Palakp41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ischolten ischolten merged commit 71e458d into master Apr 10, 2019
@ischolten ischolten deleted the feat/sync-note-scrolling branch April 10, 2019 23:54
@alexpaxton
Copy link
Contributor

So sickkkk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Palakp41 Palakp41 Palakp41 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ischolten @alexpaxton @Palakp41