feat(ui): Add custom time range option in time range dropdown #11990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
feat/time-range-calendar
branch
3 times, most recently
from
6367b0e to
ea26a71
Compare
chnn
approved these changes
Feb 19, 2019
| private get stylePosition(): CSSProperties { | ||
| const {position} = this.props | ||
| const {bottomPosition, topPosition} = this.state | ||
| const pickerHeight = 410 |
There was a problem hiding this comment.
nit Want to extract this to a named screaming snake case constant at the top of the file?
| } | ||
|
|
||
| const bottomPx = | ||
| (bottomPosition || window.innerHeight - top - 15) - pickerHeight / 2 |
There was a problem hiding this comment.
some additional padding; i can make into a constant
| (bottomPosition || window.innerHeight - top - 15) - pickerHeight / 2 | ||
| return { | ||
| bottom: `${bottomPx}px`, | ||
| right: `${right + 2}px`, |
There was a problem hiding this comment.
some additional padding; i can make it into a named constant
ischolten
force-pushed
the
feat/time-range-calendar
branch
from
ea26a71 to
f0e7f30
Compare
Co-authored-by: Daniel Campbell <metalwhirlwind@gmail.com>
ischolten
force-pushed
the
feat/time-range-calendar
branch
from
f0e7f30 to
f9aab0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11692
Briefly describe your proposed changes:
Add a '
Custom Time Rangeoption to the timerange dropdown that opens a calendar selection to choose the time rangeChange the clickOutside component to listen to
mousedownrather thanclickAdd react-datepicker as dependency
add stop to queries built by the query builder that default to
now()if a custom time is not selected