feat(ui/dataLoaders): Use env var for telegraf config auth token #11693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of auth token
ischolten
force-pushed
the
feat/telegraf-auth-envvar
branch
from
454e663 to
26e2a15
Compare
OfTheDelmer
approved these changes
Feb 5, 2019
| @@ -1,6 +1,7 @@ | |||
| ## v2.0.0-alpha.2 [unreleased] | |||
|
|
|||
| ## Features | |||
| 1. [11693](https://github.com/influxdata/influxdb/pull/11693): Save the $INFLUX_TOKEN environmental variable in telegraf configs | |||
| @@ -299,7 +299,7 @@ export const createOrUpdateTelegrafConfigAsync = (authToken: string) => async ( | |||
| type: TelegrafPluginOutputInfluxDBV2.TypeEnum.Output, | |||
| config: { | |||
| urls: ['http://127.0.0.1:9999'], | |||
| token: authToken, | |||
| token: '$INFLUX_TOKEN', | |||
There was a problem hiding this comment.
So we won't store the exact token here anymore? Does that mean the auth token will need to be fetched separately for the TelegrafInstructionsOverlay in the other PR I've got open where it was using plugin.config.token?
There was a problem hiding this comment.
Oh yes i do believe that will affect the Instructions Overlay in that way. Since we are not going to store that anymore, fetching it will be the only to get that value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11609
Briefly describe your proposed changes:
Rather than using the actual auth token for the telegraf config, the environmental variable
$INFLUX_TOKENwill now get saved into the config.