fix: efficient write blocking synchronization #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlastahajek
changed the title
vlastahajek
force-pushed
the
fix/write-blocking-mutex
branch
from
70b1de5
to
cf63131
Compare
sranka
requested changes
Sep 12, 2022
| defer w.mu.Unlock() | ||
| if !w.batching { | ||
| w.batching = true | ||
| if atomic.LoadInt32(&w.batching) == 0 { |
There was a problem hiding this comment.
Wouldn't be easier to enforce or document that EnableBatching can be called before any write is performed?
There was a problem hiding this comment.
It would be easier to document it. I don't think it will be easier to enforce it. The way how it is safe.
vlastahajek
force-pushed
the
fix/write-blocking-mutex
branch
from
cf63131
to
a936db6
Compare
sranka
approved these changes
Sep 13, 2022
vlastahajek
force-pushed
the
fix/write-blocking-mutex
branch
from
a936db6
to
9d45dd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #352
Proposed Changes
More efficient synchronization around batching related code in WriteAPIBlocking
Checklist