Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata file about latest release is updated too early #294

Open
bulletmark opened this issue Jul 25, 2024 · 5 comments
Open

Metadata file about latest release is updated too early #294

bulletmark opened this issue Jul 25, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@bulletmark
Copy link

The file available at https://raw.githubusercontent.com/indygreg/python-build-standalone/latest-release/latest-release.json is supposed to point to the latest release but I notice that it currently points to 20240725 which is in prelease. It should point to 20240713 which is the latest current release. That file should be updated only after the release is formalized.

BTW, that pending release 20240725 only has -install_only_stripped builds, no -install_only builds are present.

@bulletmark
Copy link
Author

bulletmark commented Jul 25, 2024

On checking, I find that the 20240725 builds are labelled as -install_only_stripped but are actually the unstripped binaries.

@bulletmark
Copy link
Author

I see that subsequent new release 20240726 fixes the observations mentioned above about the missing/wrong binaries in 20240725 - although that is tangential to the issue raised here.

@charliermarsh
Copy link
Collaborator

All of this is fixed though agree that file should only be updated when the release is promoted to stable. Kind of a chicken and egg problem though? The file would be temporarily stale if we only updated it after promoting.

@bulletmark
Copy link
Author

Why would it be stale? That independent file (which is not part of any release) points to the latest release and should be updated immediately after a new promotion is completed. Old releases last forever so are still valid.

When I raised this issue the file was pointing to 20240725 but Github was saying that release was "pre-release".

@charliermarsh
Copy link
Collaborator

It would be stale because it would be pointing to a release that isn't the latest release, despite being called latest-release.json :) It would still be pointing to a valid release, but it would be stale! It's clearly better than pointing to a pre-release, though.

@charliermarsh charliermarsh added the bug Something isn't working label Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants