TPE for acoustic_pulse example #351
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set updates
acoustic_pulseto have a tensor product elements option.Currently, when running with tensor product elements
--tpeand overintegration--oi, only eager works properly. When run in lazy mode--lazy, thenDiscretizationCollection._base_to_geoderiv_connection(called from_geometry_to_quad_if_requested) does not correctly return a quantity on the quadrature discretization.works:
python acoustic_pulse.py --tpeworks:
python acoustic_pulse.py --tpe --oifails:
python acoustic_pulse.py --tpe --oi --lazyThis problem affects the use of overintegration in mirgecom; seemingly TPE go into processing that is only valid when element groups are affine and simplices. (5b563de steers around the issue for now).
Overintegration appears to negatively affect the convergence rate for TPEs (see 00b6ca4)
CC: @inducer