Skip to content

Commit 41042ae

Browse files
committed
fix(scripts/buildIconsDataset.ts): icon name
1 parent 6d3d74b commit 41042ae

File tree

3 files changed

+10
-8
lines changed

3 files changed

+10
-8
lines changed

scripts/buildIconsDataset.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -149,12 +149,14 @@ async function generateIconsDataset(
149149
*/
150150
async function makeIconComponent(outputFolder: string, iconObj: Icon): Promise<void> {
151151
const txt = `<script lang="ts">
152-
import type { IconSize } from '../../../Icon.d.ts';
152+
import type { SVGProps } from '../../../Icon.d.ts';
153153
import IconBase from '../../../IconBase.svelte';
154154
155-
export let name: string = 'zoom-out';
156-
export let altText: string | undefined = undefined;
157-
export let size: IconSize | string | number = 'base';
155+
interface $$Props extends SVGProps {}
156+
157+
export let name: $$Props['name'] = '${iconObj.name}';
158+
export let altText: $$Props['altText'] = undefined;
159+
export let size: $$Props['size'] = 'base';
158160
</script>
159161
160162
<IconBase {name} {altText} {size}

src/lib/Icon.d.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,8 @@ export type Icon = {
2323
type SVGRestProps = SvelteHTMLElements['svg'];
2424

2525
interface SVGPropsInternal extends SVGRestProps {
26-
name: string;
27-
size: IconSize | string | number;
26+
name?: string;
27+
size?: IconSize | string | number;
2828
altText?: string;
2929
}
3030

src/lib/IconBase.svelte

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
1212
interface $$Props extends SVGProps {}
1313
14-
export let name: $$Props['name'];
14+
export let name: $$Props['name'] = undefined;
1515
export let altText: $$Props['altText'] = undefined;
1616
export let size: $$Props['size'] = 'base';
1717
@@ -20,7 +20,7 @@
2020
let _altText = altText ?? `${name} icon`;
2121
2222
let _size =
23-
size in sizeMap
23+
size && size in sizeMap
2424
? sizeMap[size as unknown as IconSize]
2525
: typeof size === 'number' || typeof size === 'string'
2626
? size

0 commit comments

Comments
 (0)