Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation script doesn't work for Portuguese (pt-pt) #1730

Open
micaelbatista opened this issue Feb 20, 2023 · 3 comments
Open

Translation script doesn't work for Portuguese (pt-pt) #1730

micaelbatista opened this issue Feb 20, 2023 · 3 comments
Assignees
Labels
🐛 bug 👩‍💻 tech 💬 traduction Related to the translation of the model

Comments

@micaelbatista
Copy link

micaelbatista commented Feb 20, 2023

I tried to use the yarn translation scripts to make the deepl translation to portuguese (pt-pt), but was unable, here is the output:

/mnt/d/git/nosgestesclimat$ DEEPL_API_KEY=<deepl_auth_key> yarn translate:rules
yarn run v1.22.19
warning ../package.json: No license field
$ node scripts/i18n/translate-rules.js
Parsing rules of 'data/**/*.yaml'
Getting missing rule for en-us...
Found no new entry to translate...
Getting missing rule for pt-pt...
Translating 2055 new entries to pt-pt...
pt-pt | 2053/2055 | ████████████████████████████████████████ | Translating alimentation . boisson . sucrées . facteur...

[SKIPPED] - actions:
Glossary not found, message: Not found
[SKIPPED] - actions pétrole:
Glossary not found, message: Not found
[SKIPPED] - alimentation . réduire viande . par deux:
Glossary not found, message: Not found
[SKIPPED] - alimentation . réduire viande . par deux:
Glossary not found, message: Not found
[SKIPPED] - alimentation . réduire viande . par deux . par semaine:
Glossary not found, message: Not found
...

This happens both in the nosgestesclimat, and the nosgestesclimat-site repos.

After further investigation, I found out that currently DeepL doesn't support the portuguese lang in the glossary.
Is it possible to skip the glossary and do the translation directly?

@micaelbatista micaelbatista changed the title Translation script doesn't work for Portuguese (pt-pt) | Le script de traduction ne fonctionne pas pour le portugais (pt-pt) Translation script doesn't work for Portuguese (pt-pt) Feb 20, 2023
@laem
Copy link
Contributor

laem commented Feb 21, 2023

Thanks for the report ! Yes, I think the drawbacks of not using the glossary are not primordial, we can live without it if it enables a new language :)
What do you think @EmileRolley ?

@Clemog
Copy link
Contributor

Clemog commented Feb 21, 2023

Also related : incubateur-ademe/nosgestesclimat-site#583

@EmileRolley
Copy link
Contributor

For now, DeepL's glossary is limited in pair of languages supported. Consequently, I think we need to implement ourself a glossary step in our translation workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug 👩‍💻 tech 💬 traduction Related to the translation of the model
Projects
None yet
Development

No branches or pull requests

4 participants