Controller input - fix action and undo being bound to joystick inputs instead of triggers #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down' and 'right joystick right' instead of the states of RT and LT.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, 'action' is triggered when the left joystick has just moved into a 'down' position (in addition to the expected 'down' input being triggered) instead of when RT is pressed. A similar thing happens with an "LT"-to-undo check actually checking for the right joystick being moved right. (I'm assuming this is a bug because it both feels like incorrect behaviour and contradicts the comments next to the lines of code that cause it.)
This pull request fixes that.