Skip to content

Fix a bug that deploy pr messages trigger other actions also #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2018

Conversation

tomoasleep
Copy link
Member

@tomoasleep tomoasleep commented Jun 28, 2018

This PR fixes a bug that the message @qiitan deploy pull request ... triggers other actions (such as ruboty-talk actions) in addition to the pull request action.

qiitan

(In this conversation, Ruboty creates deploy pull request in reply to my message. However, ruboty-talk's handler is also executed and a reply message is sent.)

The reason why other actions are triggered is that Ruboty judges the given message is not matched to the action if the handler of the action returns falsy value and Ruboty tries to call other handlers.
We modify Ruboty::Github::Actions::CreatePullRequest#call to always return truthy value to tell Ruboty the given message is matched and handled.

References

@tomoasleep tomoasleep requested a review from yujinakayama June 28, 2018 05:45
@tomoasleep tomoasleep changed the title Fix a bug that deploy pr messages triggers other actions also Fix a bug that deploy pr messages trigger other actions also Jun 28, 2018
Copy link

@yujinakayama yujinakayama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomoasleep
Copy link
Member Author

thx!

@tomoasleep tomoasleep merged commit 20943ca into master Jun 29, 2018
@tomoasleep tomoasleep deleted the fix-deploy-pr-handler branch June 29, 2018 01:38
@mziyut mziyut mentioned this pull request Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants