Fix a bug that deploy pr messages trigger other actions also #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug that the message
@qiitan deploy pull request ...
triggers other actions (such as ruboty-talk actions) in addition to the pull request action.(In this conversation, Ruboty creates deploy pull request in reply to my message. However, ruboty-talk's handler is also executed and a reply message is sent.)
The reason why other actions are triggered is that Ruboty judges the given message is not matched to the action if the handler of the action returns falsy value and Ruboty tries to call other handlers.
We modify
Ruboty::Github::Actions::CreatePullRequest#call
to always return truthy value to tell Ruboty the given message is matched and handled.References