Skip to content

Add new codepen embed script url public.codepenassets.com #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

P-SiZK
Copy link
Contributor

@P-SiZK P-SiZK commented Jan 22, 2025

What

Ref

@P-SiZK P-SiZK self-assigned this Jan 22, 2025
@P-SiZK P-SiZK requested review from a team and getty104 and removed request for a team January 22, 2025 07:41
@@ -6,6 +6,7 @@ module CodePen
"https://production-assets.codepen.io/assets/embed/ei.js",
"https://static.codepen.io/assets/embed/ei.js",
"https://cpwebassets.codepen.io/assets/embed/ei.js",
"https://public.codepenassets.com/embed/index.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write the spec.

shared_examples_for "override embed code attributes" do |allowed:|

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I refactored the codepen tests. And, added test for the new codepen URL.

@P-SiZK P-SiZK force-pushed the add-codepen-script-url branch from 81b9c9a to 3e0e0b1 Compare January 22, 2025 09:23
@P-SiZK P-SiZK requested a review from getty104 January 22, 2025 09:29
Copy link
Member

@getty104 getty104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@P-SiZK P-SiZK merged commit b45155e into master Jan 23, 2025
6 checks passed
@P-SiZK P-SiZK deleted the add-codepen-script-url branch January 23, 2025 02:03
@P-SiZK P-SiZK mentioned this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants