Skip to content
This repository has been archived by the owner on Dec 12, 2021. It is now read-only.

Reduce specificity for RxSwift podspec dependency #12

Merged
merged 2 commits into from
Apr 16, 2017

Conversation

jwhitley
Copy link
Contributor

s.dependency "RxSwift", "~> 3.0.0" is too specific, causing conflicts with packages using newer
versions of RxSwift in the 3.x series. Use ~> 3.0 instead.

I have updated Carthage dependencies locally, built, and run tests (all passed), but did not include the Carthage updates on this PR. Those are easy to add, if useful. Tested with Carthage versions:

github "Quick/Nimble" "v6.1.0"
github "Quick/Quick" "v1.1.0"
github "ReactiveX/RxSwift" "3.4.0"
github "mrackwitz/xcconfigs" "3.0"
github "shu223/Pulsator" "0.3.0"

"~> 3.0.0" is too specific, causing conflicts with packages using newer
versions of RxSwift in the 3.x series.
Copy link
Owner

@inamiy inamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fix!
CI failure seems unrelated to this PR, so I will fix that first and then merge this one 😉

@inamiy
Copy link
Owner

inamiy commented Apr 16, 2017

Hm, it seems Linux test keeps failing even when rebuilding a previous successful one :(
I will merge this PR for now and will investigate the issue later.

@inamiy inamiy merged commit a78fff5 into inamiy:swift/3.0 Apr 16, 2017
@inamiy
Copy link
Owner

inamiy commented Apr 16, 2017

Bumped ver 0.2.1 😉

@jwhitley
Copy link
Contributor Author

Arigato gozaimasu!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants