Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Rule: avoid high number of export_types #539

Closed
paulo-ferraz-oliveira opened this issue Sep 28, 2020 · 4 comments
Closed

New Rule: avoid high number of export_types #539

paulo-ferraz-oliveira opened this issue Sep 28, 2020 · 4 comments

Comments

@paulo-ferraz-oliveira
Copy link
Collaborator

e.g. like god_module, but for -export_type.

Ideas?

@elbrujohalcon
Copy link
Member

elbrujohalcon commented Sep 28, 2020

Is that even an issue anywhere?

I mean… people not defining enough types… I've seen a lot.
People defining too many types… I have yet to meet the first one of them.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

I didn't come up with this; I saw it in production code. 😄 If it's not an issue, sure, it's not an issue.

@elbrujohalcon
Copy link
Member

And now I want to see that code!!!

@paulo-ferraz-oliveira
Copy link
Collaborator Author

Oh, it's not shared online 😞. But I can tell you this: it's not a god module, but it has more than 20 types 😄. When I suggested the idea, it would be for a number like that: at least 20 types. No worries, though; we'll get there. There's so much more interesting stuff to implement and fix, like that ignore that's been itching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants