Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queue Resource Release #93

Open
sugus-seu opened this issue Dec 24, 2015 · 9 comments
Open

Queue Resource Release #93

sugus-seu opened this issue Dec 24, 2015 · 9 comments
Labels

Comments

@sugus-seu
Copy link

When close a apns connection, the queue resource doesn't release,which leads to a lot of useless apns queue left in system that cannot be GC.
Add apns_queue:stop in apns_connection:terminate can fix it.

@elbrujohalcon
Copy link
Member

Would you be so kind as to send a pull request with that change, please?

@sugus-seu
Copy link
Author

sugus-seu#1

@elbrujohalcon
Copy link
Member

Wait a second, @sugus-seu … that queue was started with apns_queue:start_link, therefore it's linked to the apns_connection process that created it. By the time it reaches terminate, or soon after that, the queue process will effectively die.
Can you show me the test you run where you saw a lot of useless apns queue left in the system?

@sugus-seu
Copy link
Author

Just call apns_connection:stop will close apns_connection server, but the linked apns_queue server will stay

@sugus-seu
Copy link
Author

only error single will passed to the linked process, if one server terminate normal, the linked process will not die

@elbrujohalcon
Copy link
Member

Good point, @sugus-seu.

@elbrujohalcon
Copy link
Member

@sugus-seu ^ I created a new PR for you, pointing to the main repo (this one) instead of yours.
Your changes do not compile and @elvisci is not happy with them either. Please review your code and, if possible, check if it actually compiles. When you fix that, push to your branch so that the PR gets updated and let me know.
Thanks.

@elbrujohalcon
Copy link
Member

@sugus-seu any updates on this?

@sugus-seu
Copy link
Author

#97

@ferigis ferigis added the 1.x label Feb 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants