Skip to content

Commit

Permalink
Skipping profile cleaning step
Browse files Browse the repository at this point in the history
Firefox should be able to work without this preparation activity, but we
have to watch CI carefully to ensure this is true. The reason for this
change is not just the driver performance on start. Running Firefox 40
with -silent option on the profile prepared by Selenium crashes the
browser.
barancev committed May 8, 2015
1 parent 6ee07f0 commit 6fc17a0
Showing 3 changed files with 0 additions and 15 deletions.
10 changes: 0 additions & 10 deletions java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java
Original file line number Diff line number Diff line change
@@ -237,16 +237,6 @@ public String getConsoleOutput() throws IOException {
return Streams.drainStream(stream);
}

public void clean(FirefoxProfile profile, File profileDir) throws IOException {
startProfile(profile, profileDir, "-silent");
try {
waitFor(timeout);
} catch (InterruptedException e) {
process.destroy();
throw new WebDriverException(e);
}
}

public long getTimeout() {
return timeout;
}
Original file line number Diff line number Diff line change
@@ -23,7 +23,6 @@

import org.openqa.selenium.Beta;
import org.openqa.selenium.WebDriverException;
import org.openqa.selenium.WebElement;
import org.openqa.selenium.firefox.ExtensionConnection;
import org.openqa.selenium.firefox.FirefoxBinary;
import org.openqa.selenium.firefox.FirefoxDriver;
@@ -107,8 +106,6 @@ public void start() throws IOException {
try {
profileDir = profile.layoutOnDisk();

process.clean(profile, profileDir);

String firefoxLogFile = System.getProperty(FirefoxDriver.SystemProperty.BROWSER_LOGFILE);

if (firefoxLogFile != null) {
Original file line number Diff line number Diff line change
@@ -92,8 +92,6 @@ public void start() throws IOException {

profileDir = profile.layoutOnDisk();

process.clean(profile, profileDir);

delegate = new HttpCommandExecutor(buildUrl(host, port));
delegate.setLocalLogs(logs);
String firefoxLogFile = System.getProperty(FirefoxDriver.SystemProperty.BROWSER_LOGFILE);

0 comments on commit 6fc17a0

Please sign in to comment.