Merge pull request #123 from imsweb/find-matching-table-row-npe

findMatchingTableRow is not null safe

Author: ctmay4

lib/src/main/java/com/imsweb/staging/engine/DecisionEngine.java

@@ -130,20 +130,22 @@ public static Integer findMatchingTableRow(Table table, Map<String, String> cont
         if (context == null)
             throw new IllegalStateException(_CONTEXT_MISSING_MESSAGE);
 
-        for (int i = 0; i < table.getTableRows().size(); i++) {
-            boolean matchAll = true;
-            for (ColumnDefinition col : table.getColumnDefinitions()) {
-                if (ColumnType.INPUT.equals(col.getType()) && (keysToMatch == null || keysToMatch.contains(col.getKey())))
-                    matchAll = testMatch(table.getTableRows().get(i).getColumnInput(col.getKey()), context.get(col.getKey()), context);
+        if (table.getTableRows() != null) {
+            for (int i = 0; i < table.getTableRows().size(); i++) {
+                boolean matchAll = true;
+                for (ColumnDefinition col : table.getColumnDefinitions()) {
+                    if (ColumnType.INPUT.equals(col.getType()) && (keysToMatch == null || keysToMatch.contains(col.getKey())))
+                        matchAll = testMatch(table.getTableRows().get(i).getColumnInput(col.getKey()), context.get(col.getKey()), context);
+
+                    if (!matchAll)
+                        break;
+                }
 
-                if (!matchAll)
+                // if all inputs match, we are done
+                if (matchAll) {
+                    rowIndex = i;
                     break;
-            }
-
-            // if all inputs match, we are done
-            if (matchAll) {
-                rowIndex = i;
-                break;
+                }
             }
         }
 

lib/src/test/java/com/imsweb/staging/engine/DecisionEngineTest.java

@@ -488,6 +488,22 @@ void testMatchOnSpecificKeys() {
                 .containsExactly(tuple(EndpointType.MATCH, "LINE1", "result"));
     }
 
+    @Test
+    void testMatchTableWithNoRows() {
+        InMemoryDataProvider provider = new InMemoryDataProvider("Test", "1.0");
+        StagingTable table = new StagingTable("testNoRows");
+        table.addColumnDefinition("a", ColumnType.INPUT);
+        table.addColumnDefinition("result", ColumnType.ENDPOINT);
+        provider.addTable(table);
+
+        Table tableMissing = provider.getTable("testNoRows");
+
+        Map<String, String> input = new HashMap<>();
+        input.put("a", "");
+        List<? extends Endpoint> endpoints = DecisionEngine.matchTable(tableMissing, input);
+        assertNull(endpoints);
+    }
+
     @Test
     void testMatchMissingVsAll() {
         InMemoryDataProvider provider = new InMemoryDataProvider("Test", "1.0");