From 5d2ee96900f18a106d532f8b6ccf56ddf62951d7 Mon Sep 17 00:00:00 2001 From: cyqsimon <28627918+cyqsimon@users.noreply.github.com> Date: Mon, 16 Oct 2023 17:06:00 +0800 Subject: [PATCH] CI: amend #306 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - I only installed npcap, but forgot to run the actual tests 🤦 --- .github/workflows/ci.yaml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 548ad6c2e..c1225e36b 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -88,9 +88,9 @@ jobs: - name: Run tests using cargo-insta id: run_tests - # npcap is needed to run tests on Windows, so this is an unfortunate - # sacrifice we have to make in the name of security - if: (matrix.os != 'windows-latest') || (github.event_name != 'pull_request') + # npcap is needed to run tests on Windows, so unfortunately we cannot run tests + # on PRs from other repositories + if: matrix.os != 'windows-latest' || github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.repository env: # make insta generate new snapshots in CI INSTA_UPDATE: new