[New] add TypeScript types #3097

G-Rath · 2024-11-08T03:10:02Z

For now I've just typed these out manually based on what we're using internally - while it would be good to have some tests at some point, I'm hoping/recommending not blocking on that for now as I think the types are small enough to be easy to maintain manually for the time being.

Resolves #3090

codecov · 2024-11-08T03:38:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (d5f2950) to head (192b5fb).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3097   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files          83       83           
  Lines        3583     3583           
  Branches     1252     1251    -1     
=======================================
  Hits         3394     3394           
  Misses        189      189

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ljharb · 2024-11-08T08:50:53Z

Can we add a tsc run, at least?

index.d.ts

G-Rath · 2024-11-08T17:26:21Z

Can we add a tsc run, at least?

Done - note that it requires using typescript v5 since types like @types/node require that version, which led to a weird "works locally but not in CI", but I think I've got that resolved and should be good enough for now 🤞

.github/workflows/node-4+.yml

package.json

socket-security · 2024-11-10T21:11:04Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

socket-security · 2024-12-02T18:36:48Z

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/enhanced-resolve@0.9.1	None	`0`	41 kB	sokra
npm/eslint-plugin-import@2.31.0	environment, filesystem, unsafe	`+54`	9.78 MB	ljharb
npm/find-root@1.1.0	filesystem	`0`	5.27 kB	jsdnxx
npm/interpret@1.4.0	None	`0`	14.9 kB	phated
npm/is-regex@1.2.0	None	`+1`	52.8 kB	ljharb

🚮 Removed packages: npm/@angular-eslint/template-parser@13.5.0, npm/@typescript-eslint/parser@5.62.0, npm/babel-cli@6.26.0, npm/babel-eslint@10.1.0, npm/babel-plugin-module-resolver@2.7.1, npm/babel-preset-airbnb@2.6.0, npm/babel-preset-flow@6.23.0, npm/chai@4.5.0, npm/cross-env@4.0.0, npm/eslint-doc-generator@1.7.1, npm/eslint-import-resolver-typescript@1.1.1

View full report↗︎

ljharb

I'll merge this without verifications in place, but it'll be very very important to add that soon.

michaelfaith · 2024-12-11T22:55:11Z

Nice work on this!

anmiles · 2025-01-12T08:32:02Z

@ljharb would you mind to get this published on npmjs.com, please? The latest version 2.31.0 still doesn't have this change.

ljharb · 2025-06-20T22:00:32Z

https://github.com/import-js/eslint-plugin-import/releases/tag/v2.32.0 has been released.

@GoldStrikeArch

| datasource | package | from | to | | ---------- | -------------------- | ------ | ------ | | npm | eslint-plugin-import | 2.31.0 | 2.32.0 | ## [v2.32.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2320---2025-06-20) ##### Added - add \[`enforce-node-protocol-usage`] rule and `import/node-version` setting (\[[#3024](import-js/eslint-plugin-import#3024)], thanks \[[@GoldStrikeArch](https://github.com/GoldStrikeArch)] and \[[@sevenc-nanashi](https://github.com/sevenc-nanashi)]) - add TypeScript types (\[[#3097](import-js/eslint-plugin-import#3097)], thanks \[[@G-Rath](https://github.com/G-Rath)]) - \[`extensions`]: add \`pathGroupOverrides to allow enforcement decision overrides based on specifier (\[[#3105](import-js/eslint-plugin-import#3105)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) - \[`order`]: add `sortTypesGroup` option to allow intragroup sorting of type-only imports (\[[#3104](import-js/eslint-plugin-import#3104)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) - \[`order`]: add `newlines-between-types` option to control intragroup sorting of type-only imports (\[[#3127](import-js/eslint-plugin-import#3127)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) - \[`order`]: add `consolidateIslands` option to collapse excess spacing for aesthetically pleasing imports (\[[#3129](import-js/eslint-plugin-import#3129)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) ##### Fixed - \[`no-unused-modules`]: provide more meaningful error message when no .eslintrc is present (\[[#3116](import-js/eslint-plugin-import#3116)], thanks \[[@michaelfaith](https://github.com/michaelfaith)]) - configs: added missing name attribute for eslint config inspector (\[[#3151](import-js/eslint-plugin-import#3151)], thanks \[[@NishargShah](https://github.com/NishargShah)]) - \[`order`]: ensure arcane imports do not cause undefined behavior (\[[#3128](import-js/eslint-plugin-import#3128)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) - \[`order`]: resolve undefined property access issue when using `named` ordering (\[[#3166](import-js/eslint-plugin-import#3166)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) - \[`enforce-node-protocol-usage`]: avoid a crash with some TS code (\[[#3173](import-js/eslint-plugin-import#3173)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[`order`]: codify invariants from docs into config schema (\[[#3152](import-js/eslint-plugin-import#3152)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) ##### Changed - \[Docs] \[`extensions`], \[`order`]: improve documentation (\[[#3106](import-js/eslint-plugin-import#3106)], thanks \[[@Xunnamius](https://github.com/Xunnamius)]) - \[Docs] add flat config guide for using `tseslint.config()` (\[[#3125](import-js/eslint-plugin-import#3125)], thanks \[[@lnuvy](https://github.com/lnuvy)]) - \[Docs] add missing comma (\[[#3122](import-js/eslint-plugin-import#3122)], thanks \[[@RyanGst](https://github.com/RyanGst)]) - \[readme] Update flatConfig example to include typescript config (\[[#3138](import-js/eslint-plugin-import#3138)], thanks \[[@intellix](https://github.com/intellix)]) - \[Refactor] \[`order`]: remove unnecessary negative check (\[[#3167](import-js/eslint-plugin-import#3167)], thanks \[[@JounQin](https://github.com/JounQin)]) - \[Docs] \[`no-unused-modules`]: add missing double quote (\[[#3191](import-js/eslint-plugin-import#3191)], thanks \[[@albertpastrana](https://github.com/albertpastrana)]) - \[Docs] `no-restricted-paths`: clarify wording and fix errors (\[[#3172](import-js/eslint-plugin-import#3172)], thanks \[[@greim](https://github.com/greim)])

[New] add TypeScript types

9d1f639

OlivierZal reviewed Nov 8, 2024

View reviewed changes

index.d.ts Outdated Show resolved Hide resolved

OlivierZal reviewed Nov 8, 2024

View reviewed changes

index.d.ts Show resolved Hide resolved

G-Rath force-pushed the add-types branch 2 times, most recently from 1713c9d to 58d17dc Compare November 8, 2024 17:25

ljharb reviewed Nov 9, 2024

View reviewed changes

.github/workflows/node-4+.yml Outdated Show resolved Hide resolved

package.json Show resolved Hide resolved

G-Rath requested a review from ljharb November 10, 2024 21:18

G-Rath force-pushed the add-types branch from e7392f5 to 5fc6cd3 Compare November 19, 2024 01:52

G-Rath force-pushed the add-types branch from 5fc6cd3 to 192b5fb Compare December 2, 2024 18:35

ljharb force-pushed the add-types branch from 192b5fb to 9d1f639 Compare December 11, 2024 15:10

ljharb approved these changes Dec 11, 2024

View reviewed changes

ljharb merged commit 9d1f639 into import-js:main Dec 11, 2024
342 checks passed

G-Rath deleted the add-types branch December 11, 2024 19:44

G-Rath mentioned this pull request Jun 23, 2025

chore(deps): lock file maintenance jest-community/eslint-plugin-jest#1784

Merged

1 task

kachkaev mentioned this pull request Jun 23, 2025

Release with new ESLint types? #3133

Closed

bmish mentioned this pull request Jun 26, 2025

feat: add type-checking with jsdoc TypeScript types and publish types qunitjs/eslint-plugin-qunit#571

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[New] add TypeScript types #3097

[New] add TypeScript types #3097

G-Rath commented Nov 8, 2024

Uh oh!

codecov bot commented Nov 8, 2024 •

edited

Loading

Uh oh!

ljharb commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

G-Rath commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Nov 10, 2024 •

edited

Loading

Uh oh!

socket-security bot commented Dec 2, 2024 •

edited

Loading

Uh oh!

ljharb left a comment

Uh oh!

Uh oh!

michaelfaith commented Dec 11, 2024

Uh oh!

anmiles commented Jan 12, 2025

Uh oh!

ljharb commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

[New] add TypeScript types #3097

[New] add TypeScript types #3097

Conversation

G-Rath commented Nov 8, 2024

Uh oh!

codecov bot commented Nov 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

ljharb commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

G-Rath commented Nov 8, 2024

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Nov 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

socket-security bot commented Dec 2, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ljharb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

michaelfaith commented Dec 11, 2024

Uh oh!

anmiles commented Jan 12, 2025

Uh oh!

ljharb commented Jun 20, 2025

Uh oh!

Uh oh!

codecov bot commented Nov 8, 2024 •

edited

Loading

socket-security bot commented Nov 10, 2024 •

edited

Loading

socket-security bot commented Dec 2, 2024 •

edited

Loading