-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] extensions
: handle .
and ..
properly
#2778
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also add some test cases with the "always" option where .
and ..
refer to dirs with package.json, and show that these don't error?
It seems like that may be an existing bug. I'm open to fixing it, but it looks like the case where you import a relative package (i.e. relative path to a directory containing a package.json) is broken. Some options:
Do you have any thoughts here? Additionally, I think |
Ideally I'd like this PR to either add tests documenting the current behavior (with a TODO comment if it's broken), or, tests matching the desired behavior and fixes for it. While |
I added tests that show the current behavior (says extensions are required when they shouldn't be) + TODOs |
73a7e84
to
b993075
Compare
'import * as test from ".."', | ||
].join('\n'), | ||
filename: testFilePath('./internal-modules/plugins/plugin.js'), | ||
options: [ 'ignorePackages' ], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about whether these should be always
. I think with ignorePackages
it should definitely not error, so it makes for a less ambiguous test case.
In the always + relative case it's a bit more ambiguous to me, since if we assume the relative path is in your project, you might have this set to always
because you always want someone to choose a file (within the project).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what to do here, tbh.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to merge this, and please file followup issues and/or PRs :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filed #2844!
This comment was marked as resolved.
This comment was marked as resolved.
extensions
: handle .
and ..
properly
Thank you! |
| datasource | package | from | to | | ---------- | -------------------- | ------ | ------ | | npm | eslint-plugin-import | 2.26.0 | 2.29.1 | ##### [\`v2.29.1\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2291---2023-12-14) ##### Fixed - \[`no-extraneous-dependencies`]: ignore `export type { ... } from '...'` when `includeTypes` is `false` (\[[#2919](import-js/eslint-plugin-import#2919)], thanks \[[@Pandemic1617](https://github.com/Pandemic1617)]) - \[`no-unused-modules`]: support export patterns with array destructuring (\[[#2930](import-js/eslint-plugin-import#2930)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[Deps] update `tsconfig-paths` (\[[#2447](import-js/eslint-plugin-import#2447)], thanks \[[@domdomegg](https://github.com/domdomegg)]) ##### [\`v2.29.0\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2290---2023-10-22) ##### Added - TypeScript config: add .cts and .mts extensions (\[[#2851](import-js/eslint-plugin-import#2851)], thanks \[[@Zamiell](https://github.com/Zamiell)]) - \[`newline-after-import`]: new option `exactCount` and docs update (\[[#1933](import-js/eslint-plugin-import#1933)], thanks \[[@anikethsaha](https://github.com/anikethsaha)] and \[[@reosarevok](https://github.com/reosarevok)]) - \[`newline-after-import`]: fix `exactCount` with `considerComments` false positive, when there is a leading comment (\[[#2884](import-js/eslint-plugin-import#2884)], thanks \[[@kinland](https://github.com/kinland)]) ##### [\`v2.28.1\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2281---2023-08-18) ##### Fixed - \[`order`]: revert breaking change to single nested group (\[[#2854](import-js/eslint-plugin-import#2854)], thanks \[[@yndajas](https://github.com/yndajas)]) ##### Changed - \[Docs] remove duplicate fixable notices in docs (\[[#2850](import-js/eslint-plugin-import#2850)], thanks \[[@bmish](https://github.com/bmish)]) ##### [\`v2.28.0\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2280---2023-07-27) ##### Fixed - \[`no-duplicates`]: remove duplicate identifiers in duplicate imports (\[[#2577](import-js/eslint-plugin-import#2577)], thanks \[[@joe-matsec](https://github.com/joe-matsec)]) - \[`consistent-type-specifier-style`]: fix accidental removal of comma in certain cases (\[[#2754](import-js/eslint-plugin-import#2754)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - \[Perf] `ExportMap`: Improve `ExportMap.for` performance on larger codebases (\[[#2756](import-js/eslint-plugin-import#2756)], thanks \[[@leipert](https://github.com/leipert)]) - \[`no-extraneous-dependencies`]/TypeScript: do not error when importing inline type from dev dependencies (\[[#1820](import-js/eslint-plugin-import#1820)], thanks \[[@AndyOGo](https://github.com/andyogo)]) - \[`newline-after-import`]/TypeScript: do not error when re-exporting a namespaced import (\[[#2832](import-js/eslint-plugin-import#2832)], thanks \[[@laurens-dg](https://github.com/laurens-dg)]) - \[`order`]: partial fix for \[[#2687](import-js/eslint-plugin-import#2687)] (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-duplicates`]: Detect across type and regular imports (\[[#2835](import-js/eslint-plugin-import#2835)], thanks \[[@benkrejci](https://github.com/benkrejci)]) - \[`extensions`]: handle `.` and `..` properly (\[[#2778](import-js/eslint-plugin-import#2778)], thanks \[[@benasher44](https://github.com/benasher44)]) - \[`no-unused-modules`]: improve schema (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unused-modules`]: report error on binding instead of parent export (\[[#2842](import-js/eslint-plugin-import#2842)], thanks \[[@Chamion](https://github.com/Chamion)]) ##### Changed - \[Docs] \[`no-duplicates`]: fix example schema (\[[#2684](import-js/eslint-plugin-import#2684)], thanks \[[@simmo](https://github.com/simmo)]) - \[Docs] \[`group-exports`]: fix syntax highlighting (\[[#2699](import-js/eslint-plugin-import#2699)], thanks \[[@devinrhode2](https://github.com/devinrhode2)]) - \[Docs] \[`extensions`]: reference node ESM behavior (\[[#2748](import-js/eslint-plugin-import#2748)], thanks \[[@xM8WVqaG](https://github.com/xM8WVqaG)]) - \[Refactor] \[`exports-last`]: use `array.prototype.findlastindex` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-anonymous-default-export`]: use `object.fromentries` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-unused-modules`]: use `array.prototype.flatmap` (thanks \[[@ljharb](https://github.com/ljharb)]) ##### [\`v2.27.5\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2275---2023-01-16) ##### Fixed - \[`order]`: Fix group ranks order when alphabetizing (\[[#2674](import-js/eslint-plugin-import#2674)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) ##### [\`v2.27.4\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2274---2023-01-11) ##### Fixed - `semver` should be a prod dep (\[[#2668](import-js/eslint-plugin-import#2668)]) ##### [\`v2.27.3\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2273---2023-01-11) ##### Fixed - \[`no-empty-named-blocks`]: rewrite rule to only check import declarations (\[[#2666](import-js/eslint-plugin-import#2666)]) ##### [\`v2.27.2\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2272---2023-01-11) ##### Fixed - \[`no-duplicates`]: do not unconditionally require `typescript` (\[[#2665](import-js/eslint-plugin-import#2665)]) ##### [\`v2.27.1\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2271---2023-01-11) ##### Fixed - `array.prototype.flatmap` should be a prod dep (\[[#2664](import-js/eslint-plugin-import#2664)], thanks \[[@cristobal](https://github.com/cristobal)]) ##### [\`v2.27.0\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2270---2023-01-11) ##### Added - \[`newline-after-import`]: add `considerComments` option (\[[#2399](import-js/eslint-plugin-import#2399)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-cycle`]: add `allowUnsafeDynamicCyclicDependency` option (\[[#2387](import-js/eslint-plugin-import#2387)], thanks \[[@GerkinDev](https://github.com/GerkinDev)]) - \[`no-restricted-paths`]: support arrays for `from` and `target` options (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-anonymous-default-export`]: add `allowNew` option (\[[#2505](import-js/eslint-plugin-import#2505)], thanks \[[@DamienCassou](https://github.com/DamienCassou)]) - \[`order`]: Add `distinctGroup` option (\[[#2395](import-js/eslint-plugin-import#2395)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[`no-extraneous-dependencies`]: Add `includeInternal` option (\[[#2541](import-js/eslint-plugin-import#2541)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`no-extraneous-dependencies`]: Add `includeTypes` option (\[[#2543](import-js/eslint-plugin-import#2543)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`order`]: new `alphabetize.orderImportKind` option to sort imports with same path based on their kind (`type`, `typeof`) (\[[#2544](import-js/eslint-plugin-import#2544)], thanks \[[@stropho](https://github.com/stropho)]) - \[`consistent-type-specifier-style`]: add rule (\[[#2473](import-js/eslint-plugin-import#2473)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - Add \[`no-empty-named-blocks`] rule (\[[#2568](import-js/eslint-plugin-import#2568)], thanks \[[@guilhermelimak](https://github.com/guilhermelimak)]) - \[`prefer-default-export`]: add "target" option (\[[#2602](import-js/eslint-plugin-import#2602)], thanks \[[@azyzz228](https://github.com/azyzz228)]) - \[`no-absolute-path`]: add fixer (\[[#2613](import-js/eslint-plugin-import#2613)], thanks \[[@adipascu](https://github.com/adipascu)]) - \[`no-duplicates`]: support inline type import with `inlineTypeImport` option (\[[#2475](import-js/eslint-plugin-import#2475)], thanks \[[@snewcomer](https://github.com/snewcomer)]) ##### Fixed - \[`order`]: move nested imports closer to main import entry (\[[#2396](import-js/eslint-plugin-import#2396)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-restricted-paths`]: fix an error message (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-restricted-paths`]: use `Minimatch.match` instead of `minimatch` to comply with Windows Native paths (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`order`]: require with member expression could not be fixed if alphabetize.order was used (\[[#2490](import-js/eslint-plugin-import#2490)], thanks \[[@msvab](https://github.com/msvab)]) - \[`order`]: leave more space in rankings for consecutive path groups (\[[#2506](import-js/eslint-plugin-import#2506)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) - \[`no-cycle`]: add ExportNamedDeclaration statements to dependencies (\[[#2511](import-js/eslint-plugin-import#2511)], thanks \[[@BenoitZugmeyer](https://github.com/BenoitZugmeyer)]) - \[`dynamic-import-chunkname`]: prevent false report on a valid webpack magic comment (\[[#2330](import-js/eslint-plugin-import#2330)], thanks \[[@MhMadHamster](https://github.com/mhmadhamster)]) - \[`export`]: do not error on TS export overloads (\[[#1590](import-js/eslint-plugin-import#1590)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unresolved`], \[`extensions`]: ignore type only exports (\[[#2436](import-js/eslint-plugin-import#2436)], thanks \[[@Lukas-Kullmann](https://github.com/Lukas-Kullmann)]) - `ExportMap`: add missing param to function (\[[#2589](import-js/eslint-plugin-import#2589)], thanks \[[@Fdawgs](https://github.com/Fdawgs)]) - \[`no-unused-modules`]: `checkPkgFieldObject` filters boolean fields from checks (\[[#2598](import-js/eslint-plugin-import#2598)], thanks \[[@mpint](https://github.com/mpint)]) - \[`no-cycle`]: accept Flow `typeof` imports, just like `type` (\[[#2608](import-js/eslint-plugin-import#2608)], thanks \[[@gnprice](https://github.com/gnprice)]) - \[`no-import-module-exports`]: avoid a false positive for import variables (\[[#2315](import-js/eslint-plugin-import#2315)], thanks \[[@BarryThePenguin](https://github.com/BarryThePenguin)]) ##### Changed - \[Tests] \[`named`]: Run all TypeScript test (\[[#2427](import-js/eslint-plugin-import#2427)], thanks \[[@ProdigySim](https://github.com/ProdigySim)]) - \[readme] note use of typescript in readme `import/extensions` section (\[[#2440](import-js/eslint-plugin-import#2440)], thanks \[[@OutdatedVersion](https://github.com/OutdatedVersion)]) - \[Docs] \[`order`]: use correct default value (\[[#2392](import-js/eslint-plugin-import#2392)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[meta] replace git.io link in comments with the original URL (\[[#2444](import-js/eslint-plugin-import#2444)], thanks \[[@liby](https://github.com/liby)]) - \[Docs] remove global install in readme (\[[#2412](import-js/eslint-plugin-import#2412)], thanks \[[@aladdin-add](https://github.com/aladdin-add)]) - \[readme] clarify `eslint-import-resolver-typescript` usage (\[[#2503](import-js/eslint-plugin-import#2503)], thanks \[[@JounQin](https://github.com/JounQin)]) - \[Refactor] \[`no-cycle`]: Add per-run caching of traversed paths (\[[#2419](import-js/eslint-plugin-import#2419)], thanks \[[@Nokel81](https://github.com/nokel81)]) - \[Performance] `ExportMap`: add caching after parsing for an ambiguous module (\[[#2531](import-js/eslint-plugin-import#2531)], thanks \[[@stenin-nikita](https://github.com/stenin-nikita)]) - \[Docs] \[`no-useless-path-segments`]: fix paths (\[[#2424](import-js/eslint-plugin-import#2424)], thanks \[[@s-h-a-d-o-w](https://github.com/s-h-a-d-o-w)]) - \[Tests] \[`no-cycle`]: add passing test cases (\[[#2438](import-js/eslint-plugin-import#2438)], thanks \[[@georeith](https://github.com/georeith)]) - \[Refactor] \[`no-extraneous-dependencies`] improve performance using cache (\[[#2374](import-js/eslint-plugin-import#2374)], thanks \[[@meowtec](https://github.com/meowtec)]) - \[meta] `CONTRIBUTING.md`: mention inactive PRs (\[[#2546](import-js/eslint-plugin-import#2546)], thanks \[[@stropho](https://github.com/stropho)]) - \[readme] make json for setting groups multiline (\[[#2570](import-js/eslint-plugin-import#2570)], thanks \[[@bertyhell](https://github.com/bertyhell)]) - \[Tests] \[`no-restricted-paths`]: Tests for `import type` statements (\[[#2459](import-js/eslint-plugin-import#2459)], thanks \[[@golergka](https://github.com/golergka)]) - \[Tests] \[`no-restricted-paths`]: fix one failing `import type` test case, submitted by \[[@golergka](https://github.com/golergka)], thanks \[[@azyzz228](https://github.com/azyzz228)] - \[Docs] automate docs with eslint-doc-generator (\[[#2582](import-js/eslint-plugin-import#2582)], thanks \[[@bmish](https://github.com/bmish)]) - \[readme] Increase clarity around typescript configuration (\[[#2588](import-js/eslint-plugin-import#2588)], thanks \[[@Nfinished](https://github.com/Nfinished)]) - \[Docs] update `eslint-doc-generator` to v1.0.0 (\[[#2605](import-js/eslint-plugin-import#2605)], thanks \[[@bmish](https://github.com/bmish)]) - \[Perf] \[`no-cycle`], \[`no-internal-modules`], \[`no-restricted-paths`]: use `anyOf` instead of `oneOf` (thanks \[[@ljharb](https://github.com/ljharb)], \[[@remcohaszing](https://github.com/remcohaszing)])
| datasource | package | from | to | | ---------- | -------------------- | ------ | ------ | | npm | eslint-plugin-import | 2.26.0 | 2.29.1 | ##### [\`v2.29.1\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2291---2023-12-14) ##### Fixed - \[`no-extraneous-dependencies`]: ignore `export type { ... } from '...'` when `includeTypes` is `false` (\[[#2919](import-js/eslint-plugin-import#2919)], thanks \[[@Pandemic1617](https://github.com/Pandemic1617)]) - \[`no-unused-modules`]: support export patterns with array destructuring (\[[#2930](import-js/eslint-plugin-import#2930)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[Deps] update `tsconfig-paths` (\[[#2447](import-js/eslint-plugin-import#2447)], thanks \[[@domdomegg](https://github.com/domdomegg)]) ##### [\`v2.29.0\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2290---2023-10-22) ##### Added - TypeScript config: add .cts and .mts extensions (\[[#2851](import-js/eslint-plugin-import#2851)], thanks \[[@Zamiell](https://github.com/Zamiell)]) - \[`newline-after-import`]: new option `exactCount` and docs update (\[[#1933](import-js/eslint-plugin-import#1933)], thanks \[[@anikethsaha](https://github.com/anikethsaha)] and \[[@reosarevok](https://github.com/reosarevok)]) - \[`newline-after-import`]: fix `exactCount` with `considerComments` false positive, when there is a leading comment (\[[#2884](import-js/eslint-plugin-import#2884)], thanks \[[@kinland](https://github.com/kinland)]) ##### [\`v2.28.1\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2281---2023-08-18) ##### Fixed - \[`order`]: revert breaking change to single nested group (\[[#2854](import-js/eslint-plugin-import#2854)], thanks \[[@yndajas](https://github.com/yndajas)]) ##### Changed - \[Docs] remove duplicate fixable notices in docs (\[[#2850](import-js/eslint-plugin-import#2850)], thanks \[[@bmish](https://github.com/bmish)]) ##### [\`v2.28.0\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2280---2023-07-27) ##### Fixed - \[`no-duplicates`]: remove duplicate identifiers in duplicate imports (\[[#2577](import-js/eslint-plugin-import#2577)], thanks \[[@joe-matsec](https://github.com/joe-matsec)]) - \[`consistent-type-specifier-style`]: fix accidental removal of comma in certain cases (\[[#2754](import-js/eslint-plugin-import#2754)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - \[Perf] `ExportMap`: Improve `ExportMap.for` performance on larger codebases (\[[#2756](import-js/eslint-plugin-import#2756)], thanks \[[@leipert](https://github.com/leipert)]) - \[`no-extraneous-dependencies`]/TypeScript: do not error when importing inline type from dev dependencies (\[[#1820](import-js/eslint-plugin-import#1820)], thanks \[[@AndyOGo](https://github.com/andyogo)]) - \[`newline-after-import`]/TypeScript: do not error when re-exporting a namespaced import (\[[#2832](import-js/eslint-plugin-import#2832)], thanks \[[@laurens-dg](https://github.com/laurens-dg)]) - \[`order`]: partial fix for \[[#2687](import-js/eslint-plugin-import#2687)] (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-duplicates`]: Detect across type and regular imports (\[[#2835](import-js/eslint-plugin-import#2835)], thanks \[[@benkrejci](https://github.com/benkrejci)]) - \[`extensions`]: handle `.` and `..` properly (\[[#2778](import-js/eslint-plugin-import#2778)], thanks \[[@benasher44](https://github.com/benasher44)]) - \[`no-unused-modules`]: improve schema (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unused-modules`]: report error on binding instead of parent export (\[[#2842](import-js/eslint-plugin-import#2842)], thanks \[[@Chamion](https://github.com/Chamion)]) ##### Changed - \[Docs] \[`no-duplicates`]: fix example schema (\[[#2684](import-js/eslint-plugin-import#2684)], thanks \[[@simmo](https://github.com/simmo)]) - \[Docs] \[`group-exports`]: fix syntax highlighting (\[[#2699](import-js/eslint-plugin-import#2699)], thanks \[[@devinrhode2](https://github.com/devinrhode2)]) - \[Docs] \[`extensions`]: reference node ESM behavior (\[[#2748](import-js/eslint-plugin-import#2748)], thanks \[[@xM8WVqaG](https://github.com/xM8WVqaG)]) - \[Refactor] \[`exports-last`]: use `array.prototype.findlastindex` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-anonymous-default-export`]: use `object.fromentries` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-unused-modules`]: use `array.prototype.flatmap` (thanks \[[@ljharb](https://github.com/ljharb)]) ##### [\`v2.27.5\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2275---2023-01-16) ##### Fixed - \[`order]`: Fix group ranks order when alphabetizing (\[[#2674](import-js/eslint-plugin-import#2674)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) ##### [\`v2.27.4\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2274---2023-01-11) ##### Fixed - `semver` should be a prod dep (\[[#2668](import-js/eslint-plugin-import#2668)]) ##### [\`v2.27.3\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2273---2023-01-11) ##### Fixed - \[`no-empty-named-blocks`]: rewrite rule to only check import declarations (\[[#2666](import-js/eslint-plugin-import#2666)]) ##### [\`v2.27.2\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2272---2023-01-11) ##### Fixed - \[`no-duplicates`]: do not unconditionally require `typescript` (\[[#2665](import-js/eslint-plugin-import#2665)]) ##### [\`v2.27.1\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2271---2023-01-11) ##### Fixed - `array.prototype.flatmap` should be a prod dep (\[[#2664](import-js/eslint-plugin-import#2664)], thanks \[[@cristobal](https://github.com/cristobal)]) ##### [\`v2.27.0\`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2270---2023-01-11) ##### Added - \[`newline-after-import`]: add `considerComments` option (\[[#2399](import-js/eslint-plugin-import#2399)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-cycle`]: add `allowUnsafeDynamicCyclicDependency` option (\[[#2387](import-js/eslint-plugin-import#2387)], thanks \[[@GerkinDev](https://github.com/GerkinDev)]) - \[`no-restricted-paths`]: support arrays for `from` and `target` options (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-anonymous-default-export`]: add `allowNew` option (\[[#2505](import-js/eslint-plugin-import#2505)], thanks \[[@DamienCassou](https://github.com/DamienCassou)]) - \[`order`]: Add `distinctGroup` option (\[[#2395](import-js/eslint-plugin-import#2395)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[`no-extraneous-dependencies`]: Add `includeInternal` option (\[[#2541](import-js/eslint-plugin-import#2541)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`no-extraneous-dependencies`]: Add `includeTypes` option (\[[#2543](import-js/eslint-plugin-import#2543)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`order`]: new `alphabetize.orderImportKind` option to sort imports with same path based on their kind (`type`, `typeof`) (\[[#2544](import-js/eslint-plugin-import#2544)], thanks \[[@stropho](https://github.com/stropho)]) - \[`consistent-type-specifier-style`]: add rule (\[[#2473](import-js/eslint-plugin-import#2473)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - Add \[`no-empty-named-blocks`] rule (\[[#2568](import-js/eslint-plugin-import#2568)], thanks \[[@guilhermelimak](https://github.com/guilhermelimak)]) - \[`prefer-default-export`]: add "target" option (\[[#2602](import-js/eslint-plugin-import#2602)], thanks \[[@azyzz228](https://github.com/azyzz228)]) - \[`no-absolute-path`]: add fixer (\[[#2613](import-js/eslint-plugin-import#2613)], thanks \[[@adipascu](https://github.com/adipascu)]) - \[`no-duplicates`]: support inline type import with `inlineTypeImport` option (\[[#2475](import-js/eslint-plugin-import#2475)], thanks \[[@snewcomer](https://github.com/snewcomer)]) ##### Fixed - \[`order`]: move nested imports closer to main import entry (\[[#2396](import-js/eslint-plugin-import#2396)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-restricted-paths`]: fix an error message (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-restricted-paths`]: use `Minimatch.match` instead of `minimatch` to comply with Windows Native paths (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`order`]: require with member expression could not be fixed if alphabetize.order was used (\[[#2490](import-js/eslint-plugin-import#2490)], thanks \[[@msvab](https://github.com/msvab)]) - \[`order`]: leave more space in rankings for consecutive path groups (\[[#2506](import-js/eslint-plugin-import#2506)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) - \[`no-cycle`]: add ExportNamedDeclaration statements to dependencies (\[[#2511](import-js/eslint-plugin-import#2511)], thanks \[[@BenoitZugmeyer](https://github.com/BenoitZugmeyer)]) - \[`dynamic-import-chunkname`]: prevent false report on a valid webpack magic comment (\[[#2330](import-js/eslint-plugin-import#2330)], thanks \[[@MhMadHamster](https://github.com/mhmadhamster)]) - \[`export`]: do not error on TS export overloads (\[[#1590](import-js/eslint-plugin-import#1590)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unresolved`], \[`extensions`]: ignore type only exports (\[[#2436](import-js/eslint-plugin-import#2436)], thanks \[[@Lukas-Kullmann](https://github.com/Lukas-Kullmann)]) - `ExportMap`: add missing param to function (\[[#2589](import-js/eslint-plugin-import#2589)], thanks \[[@Fdawgs](https://github.com/Fdawgs)]) - \[`no-unused-modules`]: `checkPkgFieldObject` filters boolean fields from checks (\[[#2598](import-js/eslint-plugin-import#2598)], thanks \[[@mpint](https://github.com/mpint)]) - \[`no-cycle`]: accept Flow `typeof` imports, just like `type` (\[[#2608](import-js/eslint-plugin-import#2608)], thanks \[[@gnprice](https://github.com/gnprice)]) - \[`no-import-module-exports`]: avoid a false positive for import variables (\[[#2315](import-js/eslint-plugin-import#2315)], thanks \[[@BarryThePenguin](https://github.com/BarryThePenguin)]) ##### Changed - \[Tests] \[`named`]: Run all TypeScript test (\[[#2427](import-js/eslint-plugin-import#2427)], thanks \[[@ProdigySim](https://github.com/ProdigySim)]) - \[readme] note use of typescript in readme `import/extensions` section (\[[#2440](import-js/eslint-plugin-import#2440)], thanks \[[@OutdatedVersion](https://github.com/OutdatedVersion)]) - \[Docs] \[`order`]: use correct default value (\[[#2392](import-js/eslint-plugin-import#2392)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[meta] replace git.io link in comments with the original URL (\[[#2444](import-js/eslint-plugin-import#2444)], thanks \[[@liby](https://github.com/liby)]) - \[Docs] remove global install in readme (\[[#2412](import-js/eslint-plugin-import#2412)], thanks \[[@aladdin-add](https://github.com/aladdin-add)]) - \[readme] clarify `eslint-import-resolver-typescript` usage (\[[#2503](import-js/eslint-plugin-import#2503)], thanks \[[@JounQin](https://github.com/JounQin)]) - \[Refactor] \[`no-cycle`]: Add per-run caching of traversed paths (\[[#2419](import-js/eslint-plugin-import#2419)], thanks \[[@Nokel81](https://github.com/nokel81)]) - \[Performance] `ExportMap`: add caching after parsing for an ambiguous module (\[[#2531](import-js/eslint-plugin-import#2531)], thanks \[[@stenin-nikita](https://github.com/stenin-nikita)]) - \[Docs] \[`no-useless-path-segments`]: fix paths (\[[#2424](import-js/eslint-plugin-import#2424)], thanks \[[@s-h-a-d-o-w](https://github.com/s-h-a-d-o-w)]) - \[Tests] \[`no-cycle`]: add passing test cases (\[[#2438](import-js/eslint-plugin-import#2438)], thanks \[[@georeith](https://github.com/georeith)]) - \[Refactor] \[`no-extraneous-dependencies`] improve performance using cache (\[[#2374](import-js/eslint-plugin-import#2374)], thanks \[[@meowtec](https://github.com/meowtec)]) - \[meta] `CONTRIBUTING.md`: mention inactive PRs (\[[#2546](import-js/eslint-plugin-import#2546)], thanks \[[@stropho](https://github.com/stropho)]) - \[readme] make json for setting groups multiline (\[[#2570](import-js/eslint-plugin-import#2570)], thanks \[[@bertyhell](https://github.com/bertyhell)]) - \[Tests] \[`no-restricted-paths`]: Tests for `import type` statements (\[[#2459](import-js/eslint-plugin-import#2459)], thanks \[[@golergka](https://github.com/golergka)]) - \[Tests] \[`no-restricted-paths`]: fix one failing `import type` test case, submitted by \[[@golergka](https://github.com/golergka)], thanks \[[@azyzz228](https://github.com/azyzz228)] - \[Docs] automate docs with eslint-doc-generator (\[[#2582](import-js/eslint-plugin-import#2582)], thanks \[[@bmish](https://github.com/bmish)]) - \[readme] Increase clarity around typescript configuration (\[[#2588](import-js/eslint-plugin-import#2588)], thanks \[[@Nfinished](https://github.com/Nfinished)]) - \[Docs] update `eslint-doc-generator` to v1.0.0 (\[[#2605](import-js/eslint-plugin-import#2605)], thanks \[[@bmish](https://github.com/bmish)]) - \[Perf] \[`no-cycle`], \[`no-internal-modules`], \[`no-restricted-paths`]: use `anyOf` instead of `oneOf` (thanks \[[@ljharb](https://github.com/ljharb)], \[[@remcohaszing](https://github.com/remcohaszing)])
| datasource | package | from | to | | ---------- | -------------------- | ------ | ------ | | npm | eslint-plugin-import | 2.26.0 | 2.29.1 | ## [v2.29.1](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2291---2023-12-14) ##### Fixed - \[`no-extraneous-dependencies`]: ignore `export type { ... } from '...'` when `includeTypes` is `false` (\[[#2919](import-js/eslint-plugin-import#2919)], thanks \[[@Pandemic1617](https://github.com/Pandemic1617)]) - \[`no-unused-modules`]: support export patterns with array destructuring (\[[#2930](import-js/eslint-plugin-import#2930)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[Deps] update `tsconfig-paths` (\[[#2447](import-js/eslint-plugin-import#2447)], thanks \[[@domdomegg](https://github.com/domdomegg)]) ## [v2.29.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2290---2023-10-22) ##### Added - TypeScript config: add .cts and .mts extensions (\[[#2851](import-js/eslint-plugin-import#2851)], thanks \[[@Zamiell](https://github.com/Zamiell)]) - \[`newline-after-import`]: new option `exactCount` and docs update (\[[#1933](import-js/eslint-plugin-import#1933)], thanks \[[@anikethsaha](https://github.com/anikethsaha)] and \[[@reosarevok](https://github.com/reosarevok)]) - \[`newline-after-import`]: fix `exactCount` with `considerComments` false positive, when there is a leading comment (\[[#2884](import-js/eslint-plugin-import#2884)], thanks \[[@kinland](https://github.com/kinland)]) ## [v2.28.1](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2281---2023-08-18) ##### Fixed - \[`order`]: revert breaking change to single nested group (\[[#2854](import-js/eslint-plugin-import#2854)], thanks \[[@yndajas](https://github.com/yndajas)]) ##### Changed - \[Docs] remove duplicate fixable notices in docs (\[[#2850](import-js/eslint-plugin-import#2850)], thanks \[[@bmish](https://github.com/bmish)]) ## [v2.28.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2280---2023-07-27) ##### Fixed - \[`no-duplicates`]: remove duplicate identifiers in duplicate imports (\[[#2577](import-js/eslint-plugin-import#2577)], thanks \[[@joe-matsec](https://github.com/joe-matsec)]) - \[`consistent-type-specifier-style`]: fix accidental removal of comma in certain cases (\[[#2754](import-js/eslint-plugin-import#2754)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - \[Perf] `ExportMap`: Improve `ExportMap.for` performance on larger codebases (\[[#2756](import-js/eslint-plugin-import#2756)], thanks \[[@leipert](https://github.com/leipert)]) - \[`no-extraneous-dependencies`]/TypeScript: do not error when importing inline type from dev dependencies (\[[#1820](import-js/eslint-plugin-import#1820)], thanks \[[@AndyOGo](https://github.com/andyogo)]) - \[`newline-after-import`]/TypeScript: do not error when re-exporting a namespaced import (\[[#2832](import-js/eslint-plugin-import#2832)], thanks \[[@laurens-dg](https://github.com/laurens-dg)]) - \[`order`]: partial fix for \[[#2687](import-js/eslint-plugin-import#2687)] (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-duplicates`]: Detect across type and regular imports (\[[#2835](import-js/eslint-plugin-import#2835)], thanks \[[@benkrejci](https://github.com/benkrejci)]) - \[`extensions`]: handle `.` and `..` properly (\[[#2778](import-js/eslint-plugin-import#2778)], thanks \[[@benasher44](https://github.com/benasher44)]) - \[`no-unused-modules`]: improve schema (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unused-modules`]: report error on binding instead of parent export (\[[#2842](import-js/eslint-plugin-import#2842)], thanks \[[@Chamion](https://github.com/Chamion)]) ##### Changed - \[Docs] \[`no-duplicates`]: fix example schema (\[[#2684](import-js/eslint-plugin-import#2684)], thanks \[[@simmo](https://github.com/simmo)]) - \[Docs] \[`group-exports`]: fix syntax highlighting (\[[#2699](import-js/eslint-plugin-import#2699)], thanks \[[@devinrhode2](https://github.com/devinrhode2)]) - \[Docs] \[`extensions`]: reference node ESM behavior (\[[#2748](import-js/eslint-plugin-import#2748)], thanks \[[@xM8WVqaG](https://github.com/xM8WVqaG)]) - \[Refactor] \[`exports-last`]: use `array.prototype.findlastindex` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-anonymous-default-export`]: use `object.fromentries` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-unused-modules`]: use `array.prototype.flatmap` (thanks \[[@ljharb](https://github.com/ljharb)]) ## [v2.27.5](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2275---2023-01-16) ##### Fixed - \[`order]`: Fix group ranks order when alphabetizing (\[[#2674](import-js/eslint-plugin-import#2674)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) ## [v2.27.4](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2274---2023-01-11) ##### Fixed - `semver` should be a prod dep (\[[#2668](import-js/eslint-plugin-import#2668)]) ## [v2.27.3](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2273---2023-01-11) ##### Fixed - \[`no-empty-named-blocks`]: rewrite rule to only check import declarations (\[[#2666](import-js/eslint-plugin-import#2666)]) ## [v2.27.2](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2272---2023-01-11) ##### Fixed - \[`no-duplicates`]: do not unconditionally require `typescript` (\[[#2665](import-js/eslint-plugin-import#2665)]) ## [v2.27.1](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2271---2023-01-11) ##### Fixed - `array.prototype.flatmap` should be a prod dep (\[[#2664](import-js/eslint-plugin-import#2664)], thanks \[[@cristobal](https://github.com/cristobal)]) ## [v2.27.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2270---2023-01-11) ##### Added - \[`newline-after-import`]: add `considerComments` option (\[[#2399](import-js/eslint-plugin-import#2399)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-cycle`]: add `allowUnsafeDynamicCyclicDependency` option (\[[#2387](import-js/eslint-plugin-import#2387)], thanks \[[@GerkinDev](https://github.com/GerkinDev)]) - \[`no-restricted-paths`]: support arrays for `from` and `target` options (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-anonymous-default-export`]: add `allowNew` option (\[[#2505](import-js/eslint-plugin-import#2505)], thanks \[[@DamienCassou](https://github.com/DamienCassou)]) - \[`order`]: Add `distinctGroup` option (\[[#2395](import-js/eslint-plugin-import#2395)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[`no-extraneous-dependencies`]: Add `includeInternal` option (\[[#2541](import-js/eslint-plugin-import#2541)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`no-extraneous-dependencies`]: Add `includeTypes` option (\[[#2543](import-js/eslint-plugin-import#2543)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`order`]: new `alphabetize.orderImportKind` option to sort imports with same path based on their kind (`type`, `typeof`) (\[[#2544](import-js/eslint-plugin-import#2544)], thanks \[[@stropho](https://github.com/stropho)]) - \[`consistent-type-specifier-style`]: add rule (\[[#2473](import-js/eslint-plugin-import#2473)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - Add \[`no-empty-named-blocks`] rule (\[[#2568](import-js/eslint-plugin-import#2568)], thanks \[[@guilhermelimak](https://github.com/guilhermelimak)]) - \[`prefer-default-export`]: add "target" option (\[[#2602](import-js/eslint-plugin-import#2602)], thanks \[[@azyzz228](https://github.com/azyzz228)]) - \[`no-absolute-path`]: add fixer (\[[#2613](import-js/eslint-plugin-import#2613)], thanks \[[@adipascu](https://github.com/adipascu)]) - \[`no-duplicates`]: support inline type import with `inlineTypeImport` option (\[[#2475](import-js/eslint-plugin-import#2475)], thanks \[[@snewcomer](https://github.com/snewcomer)]) ##### Fixed - \[`order`]: move nested imports closer to main import entry (\[[#2396](import-js/eslint-plugin-import#2396)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-restricted-paths`]: fix an error message (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-restricted-paths`]: use `Minimatch.match` instead of `minimatch` to comply with Windows Native paths (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`order`]: require with member expression could not be fixed if alphabetize.order was used (\[[#2490](import-js/eslint-plugin-import#2490)], thanks \[[@msvab](https://github.com/msvab)]) - \[`order`]: leave more space in rankings for consecutive path groups (\[[#2506](import-js/eslint-plugin-import#2506)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) - \[`no-cycle`]: add ExportNamedDeclaration statements to dependencies (\[[#2511](import-js/eslint-plugin-import#2511)], thanks \[[@BenoitZugmeyer](https://github.com/BenoitZugmeyer)]) - \[`dynamic-import-chunkname`]: prevent false report on a valid webpack magic comment (\[[#2330](import-js/eslint-plugin-import#2330)], thanks \[[@MhMadHamster](https://github.com/mhmadhamster)]) - \[`export`]: do not error on TS export overloads (\[[#1590](import-js/eslint-plugin-import#1590)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unresolved`], \[`extensions`]: ignore type only exports (\[[#2436](import-js/eslint-plugin-import#2436)], thanks \[[@Lukas-Kullmann](https://github.com/Lukas-Kullmann)]) - `ExportMap`: add missing param to function (\[[#2589](import-js/eslint-plugin-import#2589)], thanks \[[@Fdawgs](https://github.com/Fdawgs)]) - \[`no-unused-modules`]: `checkPkgFieldObject` filters boolean fields from checks (\[[#2598](import-js/eslint-plugin-import#2598)], thanks \[[@mpint](https://github.com/mpint)]) - \[`no-cycle`]: accept Flow `typeof` imports, just like `type` (\[[#2608](import-js/eslint-plugin-import#2608)], thanks \[[@gnprice](https://github.com/gnprice)]) - \[`no-import-module-exports`]: avoid a false positive for import variables (\[[#2315](import-js/eslint-plugin-import#2315)], thanks \[[@BarryThePenguin](https://github.com/BarryThePenguin)]) ##### Changed - \[Tests] \[`named`]: Run all TypeScript test (\[[#2427](import-js/eslint-plugin-import#2427)], thanks \[[@ProdigySim](https://github.com/ProdigySim)]) - \[readme] note use of typescript in readme `import/extensions` section (\[[#2440](import-js/eslint-plugin-import#2440)], thanks \[[@OutdatedVersion](https://github.com/OutdatedVersion)]) - \[Docs] \[`order`]: use correct default value (\[[#2392](import-js/eslint-plugin-import#2392)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[meta] replace git.io link in comments with the original URL (\[[#2444](import-js/eslint-plugin-import#2444)], thanks \[[@liby](https://github.com/liby)]) - \[Docs] remove global install in readme (\[[#2412](import-js/eslint-plugin-import#2412)], thanks \[[@aladdin-add](https://github.com/aladdin-add)]) - \[readme] clarify `eslint-import-resolver-typescript` usage (\[[#2503](import-js/eslint-plugin-import#2503)], thanks \[[@JounQin](https://github.com/JounQin)]) - \[Refactor] \[`no-cycle`]: Add per-run caching of traversed paths (\[[#2419](import-js/eslint-plugin-import#2419)], thanks \[[@Nokel81](https://github.com/nokel81)]) - \[Performance] `ExportMap`: add caching after parsing for an ambiguous module (\[[#2531](import-js/eslint-plugin-import#2531)], thanks \[[@stenin-nikita](https://github.com/stenin-nikita)]) - \[Docs] \[`no-useless-path-segments`]: fix paths (\[[#2424](import-js/eslint-plugin-import#2424)], thanks \[[@s-h-a-d-o-w](https://github.com/s-h-a-d-o-w)]) - \[Tests] \[`no-cycle`]: add passing test cases (\[[#2438](import-js/eslint-plugin-import#2438)], thanks \[[@georeith](https://github.com/georeith)]) - \[Refactor] \[`no-extraneous-dependencies`] improve performance using cache (\[[#2374](import-js/eslint-plugin-import#2374)], thanks \[[@meowtec](https://github.com/meowtec)]) - \[meta] `CONTRIBUTING.md`: mention inactive PRs (\[[#2546](import-js/eslint-plugin-import#2546)], thanks \[[@stropho](https://github.com/stropho)]) - \[readme] make json for setting groups multiline (\[[#2570](import-js/eslint-plugin-import#2570)], thanks \[[@bertyhell](https://github.com/bertyhell)]) - \[Tests] \[`no-restricted-paths`]: Tests for `import type` statements (\[[#2459](import-js/eslint-plugin-import#2459)], thanks \[[@golergka](https://github.com/golergka)]) - \[Tests] \[`no-restricted-paths`]: fix one failing `import type` test case, submitted by \[[@golergka](https://github.com/golergka)], thanks \[[@azyzz228](https://github.com/azyzz228)] - \[Docs] automate docs with eslint-doc-generator (\[[#2582](import-js/eslint-plugin-import#2582)], thanks \[[@bmish](https://github.com/bmish)]) - \[readme] Increase clarity around typescript configuration (\[[#2588](import-js/eslint-plugin-import#2588)], thanks \[[@Nfinished](https://github.com/Nfinished)]) - \[Docs] update `eslint-doc-generator` to v1.0.0 (\[[#2605](import-js/eslint-plugin-import#2605)], thanks \[[@bmish](https://github.com/bmish)]) - \[Perf] \[`no-cycle`], \[`no-internal-modules`], \[`no-restricted-paths`]: use `anyOf` instead of `oneOf` (thanks \[[@ljharb](https://github.com/ljharb)], \[[@remcohaszing](https://github.com/remcohaszing)])
| datasource | package | from | to | | ---------- | -------------------- | ------ | ------ | | npm | eslint-plugin-import | 2.26.0 | 2.29.1 | ## [v2.29.1](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2291---2023-12-14) ##### Fixed - \[`no-extraneous-dependencies`]: ignore `export type { ... } from '...'` when `includeTypes` is `false` (\[[#2919](import-js/eslint-plugin-import#2919)], thanks \[[@Pandemic1617](https://github.com/Pandemic1617)]) - \[`no-unused-modules`]: support export patterns with array destructuring (\[[#2930](import-js/eslint-plugin-import#2930)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[Deps] update `tsconfig-paths` (\[[#2447](import-js/eslint-plugin-import#2447)], thanks \[[@domdomegg](https://github.com/domdomegg)]) ## [v2.29.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2290---2023-10-22) ##### Added - TypeScript config: add .cts and .mts extensions (\[[#2851](import-js/eslint-plugin-import#2851)], thanks \[[@Zamiell](https://github.com/Zamiell)]) - \[`newline-after-import`]: new option `exactCount` and docs update (\[[#1933](import-js/eslint-plugin-import#1933)], thanks \[[@anikethsaha](https://github.com/anikethsaha)] and \[[@reosarevok](https://github.com/reosarevok)]) - \[`newline-after-import`]: fix `exactCount` with `considerComments` false positive, when there is a leading comment (\[[#2884](import-js/eslint-plugin-import#2884)], thanks \[[@kinland](https://github.com/kinland)]) ## [v2.28.1](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2281---2023-08-18) ##### Fixed - \[`order`]: revert breaking change to single nested group (\[[#2854](import-js/eslint-plugin-import#2854)], thanks \[[@yndajas](https://github.com/yndajas)]) ##### Changed - \[Docs] remove duplicate fixable notices in docs (\[[#2850](import-js/eslint-plugin-import#2850)], thanks \[[@bmish](https://github.com/bmish)]) ## [v2.28.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2280---2023-07-27) ##### Fixed - \[`no-duplicates`]: remove duplicate identifiers in duplicate imports (\[[#2577](import-js/eslint-plugin-import#2577)], thanks \[[@joe-matsec](https://github.com/joe-matsec)]) - \[`consistent-type-specifier-style`]: fix accidental removal of comma in certain cases (\[[#2754](import-js/eslint-plugin-import#2754)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - \[Perf] `ExportMap`: Improve `ExportMap.for` performance on larger codebases (\[[#2756](import-js/eslint-plugin-import#2756)], thanks \[[@leipert](https://github.com/leipert)]) - \[`no-extraneous-dependencies`]/TypeScript: do not error when importing inline type from dev dependencies (\[[#1820](import-js/eslint-plugin-import#1820)], thanks \[[@AndyOGo](https://github.com/andyogo)]) - \[`newline-after-import`]/TypeScript: do not error when re-exporting a namespaced import (\[[#2832](import-js/eslint-plugin-import#2832)], thanks \[[@laurens-dg](https://github.com/laurens-dg)]) - \[`order`]: partial fix for \[[#2687](import-js/eslint-plugin-import#2687)] (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-duplicates`]: Detect across type and regular imports (\[[#2835](import-js/eslint-plugin-import#2835)], thanks \[[@benkrejci](https://github.com/benkrejci)]) - \[`extensions`]: handle `.` and `..` properly (\[[#2778](import-js/eslint-plugin-import#2778)], thanks \[[@benasher44](https://github.com/benasher44)]) - \[`no-unused-modules`]: improve schema (thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unused-modules`]: report error on binding instead of parent export (\[[#2842](import-js/eslint-plugin-import#2842)], thanks \[[@Chamion](https://github.com/Chamion)]) ##### Changed - \[Docs] \[`no-duplicates`]: fix example schema (\[[#2684](import-js/eslint-plugin-import#2684)], thanks \[[@simmo](https://github.com/simmo)]) - \[Docs] \[`group-exports`]: fix syntax highlighting (\[[#2699](import-js/eslint-plugin-import#2699)], thanks \[[@devinrhode2](https://github.com/devinrhode2)]) - \[Docs] \[`extensions`]: reference node ESM behavior (\[[#2748](import-js/eslint-plugin-import#2748)], thanks \[[@xM8WVqaG](https://github.com/xM8WVqaG)]) - \[Refactor] \[`exports-last`]: use `array.prototype.findlastindex` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-anonymous-default-export`]: use `object.fromentries` (thanks \[[@ljharb](https://github.com/ljharb)]) - \[Refactor] \[`no-unused-modules`]: use `array.prototype.flatmap` (thanks \[[@ljharb](https://github.com/ljharb)]) ## [v2.27.5](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2275---2023-01-16) ##### Fixed - \[`order]`: Fix group ranks order when alphabetizing (\[[#2674](import-js/eslint-plugin-import#2674)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) ## [v2.27.4](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2274---2023-01-11) ##### Fixed - `semver` should be a prod dep (\[[#2668](import-js/eslint-plugin-import#2668)]) ## [v2.27.3](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2273---2023-01-11) ##### Fixed - \[`no-empty-named-blocks`]: rewrite rule to only check import declarations (\[[#2666](import-js/eslint-plugin-import#2666)]) ## [v2.27.2](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2272---2023-01-11) ##### Fixed - \[`no-duplicates`]: do not unconditionally require `typescript` (\[[#2665](import-js/eslint-plugin-import#2665)]) ## [v2.27.1](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2271---2023-01-11) ##### Fixed - `array.prototype.flatmap` should be a prod dep (\[[#2664](import-js/eslint-plugin-import#2664)], thanks \[[@cristobal](https://github.com/cristobal)]) ## [v2.27.0](https://github.com/import-js/eslint-plugin-import/blob/HEAD/CHANGELOG.md#2270---2023-01-11) ##### Added - \[`newline-after-import`]: add `considerComments` option (\[[#2399](import-js/eslint-plugin-import#2399)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-cycle`]: add `allowUnsafeDynamicCyclicDependency` option (\[[#2387](import-js/eslint-plugin-import#2387)], thanks \[[@GerkinDev](https://github.com/GerkinDev)]) - \[`no-restricted-paths`]: support arrays for `from` and `target` options (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-anonymous-default-export`]: add `allowNew` option (\[[#2505](import-js/eslint-plugin-import#2505)], thanks \[[@DamienCassou](https://github.com/DamienCassou)]) - \[`order`]: Add `distinctGroup` option (\[[#2395](import-js/eslint-plugin-import#2395)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[`no-extraneous-dependencies`]: Add `includeInternal` option (\[[#2541](import-js/eslint-plugin-import#2541)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`no-extraneous-dependencies`]: Add `includeTypes` option (\[[#2543](import-js/eslint-plugin-import#2543)], thanks \[[@bdwain](https://github.com/bdwain)]) - \[`order`]: new `alphabetize.orderImportKind` option to sort imports with same path based on their kind (`type`, `typeof`) (\[[#2544](import-js/eslint-plugin-import#2544)], thanks \[[@stropho](https://github.com/stropho)]) - \[`consistent-type-specifier-style`]: add rule (\[[#2473](import-js/eslint-plugin-import#2473)], thanks \[[@bradzacher](https://github.com/bradzacher)]) - Add \[`no-empty-named-blocks`] rule (\[[#2568](import-js/eslint-plugin-import#2568)], thanks \[[@guilhermelimak](https://github.com/guilhermelimak)]) - \[`prefer-default-export`]: add "target" option (\[[#2602](import-js/eslint-plugin-import#2602)], thanks \[[@azyzz228](https://github.com/azyzz228)]) - \[`no-absolute-path`]: add fixer (\[[#2613](import-js/eslint-plugin-import#2613)], thanks \[[@adipascu](https://github.com/adipascu)]) - \[`no-duplicates`]: support inline type import with `inlineTypeImport` option (\[[#2475](import-js/eslint-plugin-import#2475)], thanks \[[@snewcomer](https://github.com/snewcomer)]) ##### Fixed - \[`order`]: move nested imports closer to main import entry (\[[#2396](import-js/eslint-plugin-import#2396)], thanks \[[@pri1311](https://github.com/pri1311)]) - \[`no-restricted-paths`]: fix an error message (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`no-restricted-paths`]: use `Minimatch.match` instead of `minimatch` to comply with Windows Native paths (\[[#2466](import-js/eslint-plugin-import#2466)], thanks \[[@AdriAt360](https://github.com/AdriAt360)]) - \[`order`]: require with member expression could not be fixed if alphabetize.order was used (\[[#2490](import-js/eslint-plugin-import#2490)], thanks \[[@msvab](https://github.com/msvab)]) - \[`order`]: leave more space in rankings for consecutive path groups (\[[#2506](import-js/eslint-plugin-import#2506)], thanks \[[@Pearce-Ropion](https://github.com/Pearce-Ropion)]) - \[`no-cycle`]: add ExportNamedDeclaration statements to dependencies (\[[#2511](import-js/eslint-plugin-import#2511)], thanks \[[@BenoitZugmeyer](https://github.com/BenoitZugmeyer)]) - \[`dynamic-import-chunkname`]: prevent false report on a valid webpack magic comment (\[[#2330](import-js/eslint-plugin-import#2330)], thanks \[[@MhMadHamster](https://github.com/mhmadhamster)]) - \[`export`]: do not error on TS export overloads (\[[#1590](import-js/eslint-plugin-import#1590)], thanks \[[@ljharb](https://github.com/ljharb)]) - \[`no-unresolved`], \[`extensions`]: ignore type only exports (\[[#2436](import-js/eslint-plugin-import#2436)], thanks \[[@Lukas-Kullmann](https://github.com/Lukas-Kullmann)]) - `ExportMap`: add missing param to function (\[[#2589](import-js/eslint-plugin-import#2589)], thanks \[[@Fdawgs](https://github.com/Fdawgs)]) - \[`no-unused-modules`]: `checkPkgFieldObject` filters boolean fields from checks (\[[#2598](import-js/eslint-plugin-import#2598)], thanks \[[@mpint](https://github.com/mpint)]) - \[`no-cycle`]: accept Flow `typeof` imports, just like `type` (\[[#2608](import-js/eslint-plugin-import#2608)], thanks \[[@gnprice](https://github.com/gnprice)]) - \[`no-import-module-exports`]: avoid a false positive for import variables (\[[#2315](import-js/eslint-plugin-import#2315)], thanks \[[@BarryThePenguin](https://github.com/BarryThePenguin)]) ##### Changed - \[Tests] \[`named`]: Run all TypeScript test (\[[#2427](import-js/eslint-plugin-import#2427)], thanks \[[@ProdigySim](https://github.com/ProdigySim)]) - \[readme] note use of typescript in readme `import/extensions` section (\[[#2440](import-js/eslint-plugin-import#2440)], thanks \[[@OutdatedVersion](https://github.com/OutdatedVersion)]) - \[Docs] \[`order`]: use correct default value (\[[#2392](import-js/eslint-plugin-import#2392)], thanks \[[@hyperupcall](https://github.com/hyperupcall)]) - \[meta] replace git.io link in comments with the original URL (\[[#2444](import-js/eslint-plugin-import#2444)], thanks \[[@liby](https://github.com/liby)]) - \[Docs] remove global install in readme (\[[#2412](import-js/eslint-plugin-import#2412)], thanks \[[@aladdin-add](https://github.com/aladdin-add)]) - \[readme] clarify `eslint-import-resolver-typescript` usage (\[[#2503](import-js/eslint-plugin-import#2503)], thanks \[[@JounQin](https://github.com/JounQin)]) - \[Refactor] \[`no-cycle`]: Add per-run caching of traversed paths (\[[#2419](import-js/eslint-plugin-import#2419)], thanks \[[@Nokel81](https://github.com/nokel81)]) - \[Performance] `ExportMap`: add caching after parsing for an ambiguous module (\[[#2531](import-js/eslint-plugin-import#2531)], thanks \[[@stenin-nikita](https://github.com/stenin-nikita)]) - \[Docs] \[`no-useless-path-segments`]: fix paths (\[[#2424](import-js/eslint-plugin-import#2424)], thanks \[[@s-h-a-d-o-w](https://github.com/s-h-a-d-o-w)]) - \[Tests] \[`no-cycle`]: add passing test cases (\[[#2438](import-js/eslint-plugin-import#2438)], thanks \[[@georeith](https://github.com/georeith)]) - \[Refactor] \[`no-extraneous-dependencies`] improve performance using cache (\[[#2374](import-js/eslint-plugin-import#2374)], thanks \[[@meowtec](https://github.com/meowtec)]) - \[meta] `CONTRIBUTING.md`: mention inactive PRs (\[[#2546](import-js/eslint-plugin-import#2546)], thanks \[[@stropho](https://github.com/stropho)]) - \[readme] make json for setting groups multiline (\[[#2570](import-js/eslint-plugin-import#2570)], thanks \[[@bertyhell](https://github.com/bertyhell)]) - \[Tests] \[`no-restricted-paths`]: Tests for `import type` statements (\[[#2459](import-js/eslint-plugin-import#2459)], thanks \[[@golergka](https://github.com/golergka)]) - \[Tests] \[`no-restricted-paths`]: fix one failing `import type` test case, submitted by \[[@golergka](https://github.com/golergka)], thanks \[[@azyzz228](https://github.com/azyzz228)] - \[Docs] automate docs with eslint-doc-generator (\[[#2582](import-js/eslint-plugin-import#2582)], thanks \[[@bmish](https://github.com/bmish)]) - \[readme] Increase clarity around typescript configuration (\[[#2588](import-js/eslint-plugin-import#2588)], thanks \[[@Nfinished](https://github.com/Nfinished)]) - \[Docs] update `eslint-doc-generator` to v1.0.0 (\[[#2605](import-js/eslint-plugin-import#2605)], thanks \[[@bmish](https://github.com/bmish)]) - \[Perf] \[`no-cycle`], \[`no-internal-modules`], \[`no-restricted-paths`]: use `anyOf` instead of `oneOf` (thanks \[[@ljharb](https://github.com/ljharb)], \[[@remcohaszing](https://github.com/remcohaszing)])
The issue was
isExternalRootModule
was returningtrue
for these, since they had no/
in them. This fixes that.Closes #2777