[Fix] importType: fix isExternalModule calculation
#2282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Oct 29, 2021
ljharb
force-pushed
the
feature/fix-2258-external-module-no-cycle
branch
from
d05255a
to
6682e9a
Compare
ljharb
changed the title
importType: fix isExternalModule calculation
Codecov Report
@@ Coverage Diff @@
## main #2282 +/- ##
=======================================
Coverage 94.64% 94.64%
=======================================
Files 65 65
Lines 2687 2687
Branches 889 889
=======================================
Hits 2543 2543
Misses 144 144
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a test that was red before the fix (and added some tests for the unix separator)
Fixes #2258.