[New] no-unused-modules: support dynamic imports [2] #2212

Hypnosphi · 2021-08-30T16:57:23Z

Replaces #1660

See import-js#1660, import-js#2212. Co-authored-by: Max Komarychev <maxkomarychev@gmail.com> Co-authored-by: Filipp Riabchun <filipp.riabchun@jetbrains.com> Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

All occurences of `import('...')` are treated as namespace imports (`import * as X from '...'`) See import-js#1660, import-js#2212. Co-authored-by: Max Komarychev <maxkomarychev@gmail.com> Co-authored-by: Filipp Riabchun <filipp.riabchun@jetbrains.com> Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

ljharb · 2021-08-30T17:09:51Z

oof, please don't make new PRs (but please leave this one open, since now I have to keep it in sync with #1660 until both are merged)

Hypnosphi · 2021-08-30T17:16:18Z

Sorry, the scheme with two branches for one PR apparently didn't work well, at least for me. Tests are passing in my branch, I have no idea what broke them in the original branch

ljharb · 2021-08-30T17:25:31Z

Probably something that landed in master in the interim, since the branches shouldn't be any different.

Hypnosphi · 2021-08-30T17:25:53Z

My branch is up-to date with master

Hypnosphi · 2021-08-30T18:18:15Z

All green now

.github/workflows/node-4+.yml

Extracted from import-js#2212 / import-js#1660.

ljharb · 2021-09-01T02:21:55Z

post rebase, travis-ci is failing, with Error: Cannot find module 'eslint-module-utils/visit' - despite 968dda1 (which wasn't required for travis tests to be passing before)

codecov · 2021-09-01T09:14:24Z

Codecov Report

Merging #2212 (968dda1) into main (35bd977) will decrease coverage by 1.12%.
The diff coverage is n/a.

❗ Current head 968dda1 differs from pull request most recent head 7c382f0. Consider uploading reports for the commit 7c382f0 to get more accurate results

@@            Coverage Diff             @@
##             main    #2212      +/-   ##
==========================================
- Coverage   84.28%   83.16%   -1.13%     
==========================================
  Files          93       93              
  Lines        2971     2987      +16     
  Branches      881      879       -2     
==========================================
- Hits         2504     2484      -20     
- Misses        467      503      +36

Impacted Files	Coverage Δ
utils/declaredScope.js	`83.33% <0.00%> (-16.67%)`	⬇️
utils/parse.js	`71.79% <0.00%> (-15.71%)`	⬇️
utils/hash.js	`85.29% <0.00%> (-14.71%)`	⬇️
utils/module-require.js	`87.50% <0.00%> (-12.50%)`	⬇️
utils/ModuleCache.js	`90.00% <0.00%> (-10.00%)`	⬇️
utils/ignore.js	`87.50% <0.00%> (-9.06%)`	⬇️
utils/moduleVisitor.js	`91.80% <0.00%> (-8.20%)`	⬇️
utils/resolve.js	`92.91% <0.00%> (-7.09%)`	⬇️
resolvers/node/index.js	`91.42% <0.00%> (-5.55%)`	⬇️
src/rules/no-unresolved.js	`100.00% <0.00%> (ø)`
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35bd977...7c382f0. Read the comment docs.

Hypnosphi · 2021-09-01T09:33:17Z

For some reason, I don't see npm run pretest in the job log: https://app.travis-ci.com/github/import-js/eslint-plugin-import/jobs/534928091

ljharb · 2021-09-01T14:10:19Z

hm, you're right, i don't see that either. Maybe after_install isn't a thing, i'll fix that.

aladdin-add · 2021-09-15T05:32:22Z

👍 awesome! thx for fixing this!

Meemaw · 2021-09-22T12:19:37Z

Hey, is it possible to release this? 🙏

maxkomarychev and others added 2 commits June 20, 2020 15:10

[utils] [new] add visit, to support dynamic imports

7579748

See import-js#1660, import-js#2212. Co-authored-by: Max Komarychev <maxkomarychev@gmail.com> Co-authored-by: Filipp Riabchun <filipp.riabchun@jetbrains.com> Co-authored-by: 薛定谔的猫 <weiran.zsd@outlook.com>

Hypnosphi force-pushed the no-unused-modules-dynamic-imports branch from e69c056 to 86a87d3 Compare August 30, 2021 17:03

ljharb marked this pull request as draft August 30, 2021 17:09

Hypnosphi force-pushed the no-unused-modules-dynamic-imports branch 2 times, most recently from 63c3c5a to b724db8 Compare August 30, 2021 17:37

ljharb reviewed Aug 30, 2021

View reviewed changes

.github/workflows/node-4+.yml Outdated Show resolved Hide resolved

ljharb pushed a commit to ljharb/eslint-plugin-import that referenced this pull request Aug 30, 2021

[Tests] run pretest on CI

397b6c5

Extracted from import-js#2212 / import-js#1660.

Hypnosphi changed the title ~~[New] no-unused-modules: support dynamic imports~~ [New] no-unused-modules: support dynamic imports [2] Aug 30, 2021

ljharb force-pushed the no-unused-modules-dynamic-imports branch 2 times, most recently from 329454c to 3d8cc76 Compare September 1, 2021 02:14

ljharb force-pushed the main branch from 968dda1 to a032b83 Compare September 1, 2021 14:18

ljharb force-pushed the no-unused-modules-dynamic-imports branch from 3d8cc76 to b0acc6e Compare September 1, 2021 14:18

ljharb force-pushed the no-unused-modules-dynamic-imports branch from b0acc6e to b7bf750 Compare September 14, 2021 23:29

ljharb approved these changes Sep 14, 2021

View reviewed changes

ljharb marked this pull request as ready for review September 14, 2021 23:30

ljharb force-pushed the no-unused-modules-dynamic-imports branch from b7bf750 to 7c382f0 Compare September 14, 2021 23:34

ljharb merged commit 7c382f0 into import-js:main Sep 15, 2021

danielbachhuber mentioned this pull request Oct 13, 2021

Bump eslint-plugin-import from 2.24.2 to 2.25.2 Strategy11/nutrifox-plugin#261

Merged

sync-by-unito bot mentioned this pull request Nov 1, 2021

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.25.2 numbersprotocol/capture-lite#1026

Closed

sync-by-unito bot mentioned this pull request Dec 1, 2021

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.25.3 numbersprotocol/capture-lite#1066

Closed

This was referenced Dec 31, 2021

[utils] [patch] Fix @babel/eslint-parser 8 compatibility #2343

Merged

Huge import/no-cycle performance downgrade in 2.25.3 #2348

Closed

sync-by-unito bot mentioned this pull request Feb 1, 2022

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.25.4 numbersprotocol/capture-lite#1230

Closed

sync-by-unito bot mentioned this pull request May 1, 2022

build(deps-dev): bump eslint-plugin-import from 2.24.2 to 2.26.0 numbersprotocol/capture-lite#1581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[New] no-unused-modules: support dynamic imports [2] #2212

[New] no-unused-modules: support dynamic imports [2] #2212

Hypnosphi commented Aug 30, 2021 •

edited

Loading

ljharb commented Aug 30, 2021

Hypnosphi commented Aug 30, 2021 •

edited

Loading

ljharb commented Aug 30, 2021

Hypnosphi commented Aug 30, 2021

Hypnosphi commented Aug 30, 2021

ljharb commented Sep 1, 2021 •

edited

Loading

codecov bot commented Sep 1, 2021 •

edited

Loading

Hypnosphi commented Sep 1, 2021

ljharb commented Sep 1, 2021

aladdin-add commented Sep 15, 2021

Meemaw commented Sep 22, 2021

[New] no-unused-modules: support dynamic imports [2] #2212

[New] no-unused-modules: support dynamic imports [2] #2212

Conversation

Hypnosphi commented Aug 30, 2021 • edited Loading

ljharb commented Aug 30, 2021

Hypnosphi commented Aug 30, 2021 • edited Loading

ljharb commented Aug 30, 2021

Hypnosphi commented Aug 30, 2021

Hypnosphi commented Aug 30, 2021

ljharb commented Sep 1, 2021 • edited Loading

codecov bot commented Sep 1, 2021 • edited Loading

Codecov Report

Hypnosphi commented Sep 1, 2021

ljharb commented Sep 1, 2021

aladdin-add commented Sep 15, 2021

Meemaw commented Sep 22, 2021

Hypnosphi commented Aug 30, 2021 •

edited

Loading

Hypnosphi commented Aug 30, 2021 •

edited

Loading

ljharb commented Sep 1, 2021 •

edited

Loading

codecov bot commented Sep 1, 2021 •

edited

Loading