Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] order: fix alphabetical sorting #2071

Merged
merged 1 commit into from
May 14, 2021
Merged

[Fix] order: fix alphabetical sorting #2071

merged 1 commit into from
May 14, 2021

Conversation

geraintwhite
Copy link
Contributor

@geraintwhite geraintwhite commented May 14, 2021 •
edited
Loading

Fixes #2064

Added a new test for the broken scenario.

@geraintwhite geraintwhite mentioned this pull request May 14, 2021
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 82.372% when pulling 389a37f on grit96:fix-2064 into 8213543 on benmosher:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 82.372% when pulling 389a37f on grit96:fix-2064 into 8213543 on benmosher:master.

@coveralls
Copy link

coveralls commented May 14, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.9%) to 82.372% when pulling 83f3c3e on grit96:fix-2064 into 8213543 on benmosher:master.

ljharb
ljharb approved these changes May 14, 2021
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I added another test case as well.

@ljharb ljharb mentioned this pull request May 14, 2021
Closed
@ljharb ljharb merged commit 83f3c3e into import-js:master May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

v2.23 broke alphabetical sorting
3 participants
@geraintwhite @coveralls @ljharb