[New] no-unused-modules: Support destructuring
#1997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-h-a-d-o-w
force-pushed
the
no-unused-modules_destructuring
branch
from
04bc1b9
to
1f3fb2e
Compare
s-h-a-d-o-w
force-pushed
the
no-unused-modules_destructuring
branch
from
1f3fb2e
to
c73b4ce
Compare
|
Whoops, hadn't realized that my fork was horribly out of date. 🤦 I don't think that I can do anything about that failed appveyor build though. Doesn't seem related to my contribution? |
|
Does this perhaps close #918? |
ljharb
force-pushed
the
no-unused-modules_destructuring
branch
from
c73b4ce
to
a6a85cc
Compare
ljharb
approved these changes
May 12, 2021
ljharb
changed the title
no-unused-modules: Support destructuringno-unused-modules: Support destructuring
|
Nope, but it looks like that issue already got resolved along the way at some point because I wasn't able to reproduce that error just now. |
ljharb
force-pushed
the
no-unused-modules_destructuring
branch
from
fee7248
to
ab0181d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when using a destructuring assignment with
export, errors like this are thrown:This PR fixes that issue.
Since the reasoning here seemed quite straightforward to me, I figured I'd jump straight to a PR. :)
(Minor question out of sheer curiosity: In tests, why the code duplication with code-to-be-linted in files but then also as strings within the tests?)