-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] newline-after-import
: respect decorator annotations
#1985
Conversation
this is my fr pr ever to Github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congrats! To link the PR with an issue, edit either the OP of the PR, and/or the commit message, to contain a phrase like Fixes #1784
(or "closes", "resolves", etc - there's a bunch).
The appveyor WSL failures can be ignored, they always fail.
I'm not sure why the webpack resolver tests are failing; I'll look into it.
Looks like today's npm 7 promotion caused some tests to break on master. I'll fix those, and then rebase your PR on top of it. |
@ljharb do you have any updates? |
newline-after-import
: respect decorator annotations
@lilling i've fixed master, so it looks like these are real failures. Please mark this PR as ready for review once you've figured them out :-) |
I'm seeing a few flaky failures in other PRs, so it might not actually be your branch. Stand by :-) |
@ljharb Any updates? |
ESLint got error on
|
hey! found the bug. here in my pr enjoy!
how do I link it with #1784 ?