[WIP] add allow/deny list options to no-namespace rule #1916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Jan 26, 2021
| type: 'object', | ||
| properties: { | ||
| allowList: { | ||
| type: 'array', |
There was a problem hiding this comment.
let's make sure both of these arrays must have unique items.
src/rules/no-namespace.js
Outdated
Comment on lines
129
to
132
| for (const identifier of identifiers) { | ||
| if (list.includes(identifier)) { | ||
| return mode === 'deny' | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (const identifier of identifiers) { | |
| if (list.includes(identifier)) { | |
| return mode === 'deny' | |
| } | |
| } | |
| } | |
| return mode === 'deny' && identifiers.some((identifier) => list.includes(identifier)); | |
| } |
|
I rebased this; tests are still failing so it still needs some work. |
ljharb
force-pushed
the
feature/no-namespace-options
branch
from
7b745bd
to
4d8e743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1903
This is a starting point for adding this option. Unfortunately, I cannot get the tests to run on my local machine, so I am looking for help getting this tested so it can be merged.
Edit: it's worth noting that this is based on PR #1679 from earlier this year, with the primary difference being that this version of the option checks the namespace identifier rather than the variable name.