-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] max-dependencies
: add option ignoreTypeImports
#1847
Conversation
3 similar comments
This will also fix #1136, won't it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! You added two test cases with babel-eslint, which covers flow - could we also add some that use TS?
@ljharb I added some tests using the TS parser. But as syntax for type import looks identical for flow and TS, I am not sure if that is what you were asking for. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM pending the one comment
Hi, I'm running into this issue a lot and keep having to put |
max-dependencies
: add option ignoreTypeImports
b772ad0
to
b743a65
Compare
Would be nice to document this option over here. |
Adds support for ignoring type imports.
Fixes #1843. Fixes #1136.