-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fix for Windows Subsystem for Linux #1786
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Can you provide a test that would fail without this fix?
These tests fail when running |
3 similar comments
ahhh so the existing tests do cover it, but we're not actually running tests on WSL - just on normal windows. If you already know how to add that to appveyor or travis, then that would be amazing, but if not, that is also OK and we can punt it to later. |
Ouch... looks like |
@ljharb is it possible to run Though WSL works now, the npm-tests still fail which is very strange. |
@ljharb as expected, "CASE_SENSITIVE_FS" is Any idea what might be buggy here? |
@ljharb I can't help it - Any other idea on how to fix it? |
@ljharb sorry for spaming you with notifications When only running Should I change the |
Yes, that sounds like a great idea. |
@ljharb Alright, made it! After doing so, this project's fully Windows compatible (using WSL, at least) |
Yes, that would be amazing, thanks. I don't have any Windows machines to test, so Appveyor is the only validation this project really has. |
Looks like node 8 and 14 "Native" tests are still failing. I've rebased this (and squashed and added a changelog entry), so let's see what happens. |
- Update appveyor-config to include wsl
Looks like Babel is causing trouble |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests
hmm, now all the native tests are failing - but on the coveralls step, all the tests are passing on node 10 and 12 (node 14 still fails with "Cannot find module 'C:\projects\eslint-plugin-import\node", and node 8 still fails with a ton of "Path must be a string. Received undefined" errors) However, all those tests were already failing the same way on master, so this still seems worth landing for now, as-is. |
This PR will add support for Windows Subsystem for Linux.
Windows Subsystem for Linux seems to have quite a weird treatment with file and directory-names.
While directories are case-sensitive (directory
./tests
exists while./TeSts
doesn't), files don't seem to be (bothreSOLVE.js
andresolve.js
exist).This PR adds WSL-support by checking whether both directories and files are case-sensitive before setting
CASE_SENSITIVE_FS
.