[Fix] no-duplicates: Handle TS import type

[kmui2]

Fixes #1667

Don't merge yet!

This PR contains a new test for TypeScript 3.8's new import type syntax. However, TypeScript 3.8 is still not supported yet for TypeScript ESLint! See #1667 (comment).

Updates the following TypeScript packages.

    "@typescript-eslint/parser": "^2.22.0",
    "eslint-import-resolver-typescript": "^2.0.0",
    "typescript": "^3.8.3",

As of this TypeScript ESLint package version, it will continue to produce the following error until TypeScript ESLint gains support for TypeScript 3.8 (progress can be tracked here):

AssertionError [ERR_ASSERTION] [ERR_ASSERTION]: A fatal parsing error occurred in autofix: Parsing error: '{' expected.

Update

TypeScript 3.8 import type is now supported in TypeScript ESLint v2.23.0: https://github.com/typescript-eslint/typescript-eslint/releases/tag/v2.23.0

[coveralls]

Coverage remained the same at 97.808% when pulling 9516152 on kmui2:ts-import-type into caf45a6 on benmosher:master.

[coveralls]

Coverage decreased (-6.9%) to 90.881% when pulling 162c0e1 on kmui2:ts-import-type into efd6be1 on benmosher:master.

[coveralls]

Coverage decreased (-6.9%) to 90.881% when pulling 162c0e1 on kmui2:ts-import-type into efd6be1 on benmosher:master.

[BPScott]

typescript-estree v2.23.0 has been released which contains support for the import/export type format.

It doesn't touch the export * as ns and ECMAScript private fields stuff that was also in TS 3.8 as those AST specs aren't yet finalized but it doesn't look like this PR cares about that functionality

[ljharb]

@kmui2 it seems like tests are failing :-/

[kmui2]

@ljharb I'll upgrade to typescript-eslint 2.23.0 and see if they pass. Seems they added the import type support.

[ljharb]

Worth a shot; but ^2.22.0 already includes 2.23.

[kmui2]

Worth a shot; but ^2.22.0 already includes 2.23.

I think the tests ran before 2.23.0 was released. Anyway, I ran it locally after upgrading and my new import type test seems to pass now. Let's hope the CI tests pass as well.

[ljharb]

Still some failures :-/

[kmui2]

I'll come back again and fix the tests. They seem to just fail whenever ESLINT_VERSION >= 4.

[ljharb]

Let's try to handle import/order as well #1667 (comment)

[kmui2]

I'm not sure what's going on with ESLINT_VERSION=6 test:

https://travis-ci.org/github/benmosher/eslint-plugin-import/jobs/661380703?utm_medium=notification&utm_source=github_status

I had it passing with ESLint at v6.x.x on my local.

[kmui2]

I'm really stuck here with the test for Node 13 w/ ESLint version 6. Need to pull in help on this. I am not able to reproduce this.

[ljharb]

I've rebased this, and it passes, so ¯\_(ツ)_/¯

[kmui2]

@ljharb, big thanks on helping finally get this merged! I realize I haven't created a test for the import/order case here. We can do in another PR soon.

[ljharb]

Thanks, that'd be great :-)