Make no-namespace rule fixable #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add guards to avoid crashing older versions of ESLint - Note that no-namespace's --fix requires ESLint 5+ - Prevent no-namespace --fix tests from running under ESLint < 5
ljharb
force-pushed
the
no-namespace-autofix
branch
from
5743a13
to
15675e7
Compare
ljharb
requested changes
Aug 19, 2019
ljharb
approved these changes
Oct 8, 2019
ljharb
force-pushed
the
no-namespace-autofix
branch
from
cdff101
to
d030d8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for
--fixto theno-namespacerule, in the case where all references to the namespace can be statically resolved:Input
Output
The motivation for this is to make it easier to opt in to
no-namespacein codebases that are already using this pattern. It sure beats having to do it all by hand! 😄Note that this will only work under ESLint 5+, as older versions don't allow for traversing upward from variable references. That is, in this code
identifier.parentisundefined. I haven't been able to figure out a good way to support this under ESLint 4 (let me know if you have any ideas!), so I've added a note for this in the rule's documentation.