Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] order: add fixer for destructuring commonjs import #1372

Merged
merged 1 commit into from
Jun 3, 2019
Merged

[New] order: add fixer for destructuring commonjs import #1372

merged 1 commit into from
Jun 3, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented May 29, 2019

fixes #1337

@coveralls
Copy link

coveralls commented May 29, 2019 •
edited
Loading

Coverage Status

Coverage increased (+2.6%) to 97.803% when pulling 15e5c61 on golopot:fix-order-destructuring into 9a0455e on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.802% when pulling 636b6f6 on golopot:fix-order-destructuring into ca4bf95 on benmosher:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.802% when pulling 636b6f6 on golopot:fix-order-destructuring into ca4bf95 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.802% when pulling 636b6f6 on golopot:fix-order-destructuring into ca4bf95 on benmosher:master.

ljharb
ljharb requested changes May 30, 2019
View reviewed changes
src/rules/order.js Show resolved Hide resolved
golopot
golopot commented May 30, 2019
View reviewed changes
src/rules/order.js Outdated Show resolved Hide resolved
@ljharb ljharb changed the title [Fix] order: add fixer for destructuring commonjs import [New] order: add fixer for destructuring commonjs import Jun 3, 2019
@ljharb ljharb merged commit 15e5c61 into import-js:master Jun 3, 2019
@golopot golopot deleted the fix-order-destructuring branch September 7, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fixer of import/order does not work when destructuring a commomjs module
3 participants
@golopot @coveralls @ljharb