[Generic Import Callback] Make callback for all import once in rules

[ljqx]

This PR fixes #1230.

Not only for import/extensions, this PR also adds supports of all

1. ImportDeclaration,
2. ExportNamedDeclaration,
3. ExportAllDeclaration,
4. static require CallExpression

for rules import/extensions, import/max-dependencies, import/no-extraneous-dependencies, import/no-internal-modules, import/no-nodejs-modules, import/no-restricted-paths, import/no-self-import, import/no-webpack-loader-syntax by abstracting out the common part for these callbacks.

Tests are added for import/extensions.

[ljqx]

here this PR changes the behavior, but according to the code, it should be a hidden bug and this change fixes it

[coveralls]

Coverage increased (+0.03%) to 97.986% when pulling 93e060f on ljqx:generic-import-callback into 2ae68c1 on benmosher:master.

[ljqx]

Coverage check fails because this PR reduces sources lines, though uncovered lines don't increase...

[ljharb]

can this use object spread?

[ljqx]

Yes, but we need add the babel plugin for that. If it's ok, I can add it in this PR
https://github.com/benmosher/eslint-plugin-import/blob/798eed7e559adab2eac07bf1b3e3518d4b7a4296/.babelrc#L2

[ljharb]

In that case, let's do that in a separate PR, that also lints using prefer-object-spread.

[ljqx]

Sure :)

[ljharb]

@ljqx i've rebased this, but some tests are failing now. could you take a look?

[brodycj]

This update could help with a lint task on Prettier. Is there anything we can do to help get this update finalized and ready for an upcoming release?

I did take a quick look at the build failures from last year, found messages like this:

AssertionError [ERR_ASSERTION]: A fatal parsing error occurred: Parsing error: Export 'bar' is not defined

I wonder if something in the stack had become stricter over time.

[benmosher]

sorry it's 23 months later, but LGTM 👍🏼😅

[ljharb]

@ljqx any chance you'd be able to rebase this? it's a bit hairy.

[ljqx]

Hi, Ben and Jordan, updated, and replaced the introduced helper function with existing eslint-module-utils/moduleVisitor

[ljqx]

The travis and coverage have passed :)