-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix overwriting of dynamic import() CallExpression #1218
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix import() to work with no-cycle - add tests using multiple imports in no-cycle Fixes import-js#1035. Fixes import-js#1166.
ljharb
reviewed
Oct 21, 2018
vikr01
force-pushed
the
fix/dynamic-import
branch
from
October 22, 2018 05:38
e942dff
to
27c04de
Compare
ljharb
reviewed
Oct 22, 2018
ljharb
approved these changes
Oct 22, 2018
benmosher
approved these changes
Jan 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks! need to re-run tests for this after #1254 lands but otherwise LGTM!
any updates here? Would be great to have this merged |
ljharb
force-pushed
the
fix/dynamic-import
branch
from
April 12, 2019 00:44
1db4155
to
70a59fe
Compare
This was referenced May 13, 2019
This was referenced Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1035
Closes #1166
So turns out, dynamic imports were already supported in
moduleVisitor
but they were being overwritten ifcommonjs
oramd
options were set.CallExpression
and including it in the function that's overwriting it.import()
in rules using themoduleVisitor
. Not sure why, but I couldn't get theno-cycle
rule to throw errors withimport()
.babel-eslint
not working withno-cycle
, due to the "flow workaround" foreslint@<5
This might be breaking for some users, though.
Also since
import()
can work with URLs, maybe we should use something likeisURL
fromvalidator
to ignore URL imports?