Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add no-named-export + docs/tests #1157

Merged
merged 4 commits into from
Sep 9, 2018
Merged

Add no-named-export + docs/tests #1157

merged 4 commits into from
Sep 9, 2018

Conversation

fsmaia
Copy link
Contributor

@fsmaia fsmaia commented Aug 9, 2018

Fixes #1156.

@fsmaia fsmaia changed the title No named export Add no-named-export + docs/tests Aug 9, 2018
@coveralls
Copy link

coveralls commented Aug 9, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 97.151% when pulling c506c5c on fsmaia:no-named-export into 2d4f651 on benmosher:master.

ljharb
ljharb approved these changes Aug 11, 2018
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/rules/no-named-export.js Outdated
return {}
}

const preferDefault = 'Prefer default export.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message could be a bit stricter.

@fsmaia
Copy link
Contributor Author

fsmaia commented Aug 22, 2018

Any news?

@benmosher benmosher merged commit f04b7b6 into import-js:master Sep 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@benmosher benmosher benmosher approved these changes

@jfmengels jfmengels Awaiting requested review from jfmengels

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fsmaia @coveralls @ljharb @benmosher