add option esmodule to no-dynamic-require

import-js · Oct 26, 2018 · 836eeab · 836eeab
1 parent db471a8
commit 836eeab
Show file tree

Hide file tree

Showing 2 changed files with 102 additions and 2 deletions.
diff --git a/src/rules/no-dynamic-require.js b/src/rules/no-dynamic-require.js
@@ -8,6 +8,12 @@ function isRequire(node) {
     node.arguments.length >= 1
 }
 
+function isDynamicImport(node) {
+  return node &&
+    node.callee &&
+    node.callee.type === 'Import'
+}
+
 function isStaticValue(arg) {
   return arg.type === 'Literal' ||
     (arg.type === 'TemplateLiteral' && arg.expressions.length === 0)
@@ -18,17 +24,37 @@ module.exports = {
     docs: {
       url: docsUrl('no-dynamic-require'),
     },
+    schema: [
+      {
+        type: 'object',
+        properties: {
+          esmodule: {
+            type: 'boolean',
+          },
+        },
+        additionalProperties: false,
+      },
+    ],
   },
 
   create: function (context) {
+    const options = context.options[0] || {}
+
     return {
       CallExpression(node) {
-        if (isRequire(node) && !isStaticValue(node.arguments[0])) {
-          context.report({
+        if(!node.arguments[0] || isStaticValue(node.arguments[0])) return
+        if (isRequire(node)) {
+          return context.report({
             node,
             message: 'Calls to require() should use string literals',
           })
         }
+        else if(options.esmodule && isDynamicImport(node)) {
+          return context.report({
+            node,
+            message: 'Calls to import() should use string literals',
+          })
+        }
       },
     }
   },

diff --git a/tests/src/rules/no-dynamic-require.js b/tests/src/rules/no-dynamic-require.js
@@ -10,6 +10,11 @@ const error = {
   message: 'Calls to require() should use string literals',
 }
 
+const dynamicImportError = {
+  ruleId: 'no-dynamic-require',
+  message: 'Calls to import() should use string literals',
+}
+
 ruleTester.run('no-dynamic-require', rule, {
   valid: [
     test({ code: 'import _ from "lodash"'}),
@@ -23,6 +28,48 @@ ruleTester.run('no-dynamic-require', rule, {
     test({ code: 'var foo = require(`foo`)'}),
     test({ code: 'var foo = require("./foo")'}),
     test({ code: 'var foo = require("@scope/foo")'}),
+
+    //dynamic import
+    test({
+      code: 'import("foo")',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'import(`foo`)',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'import("./foo")',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'import("@scope/foo")',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'var foo = import("foo")',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'var foo = import(`foo`)',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'var foo = import("./foo")',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'var foo = import("@scope/foo")',
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
   ],
   invalid: [
     test({
@@ -44,6 +91,33 @@ ruleTester.run('no-dynamic-require', rule, {
     test({
       code: 'require(name + "foo", "bar")',
       errors: [error],
+      options: [{esmodule: true}],
+    }),
+
+    // dynamic import
+    test({
+      code: 'import("../" + name)',
+      errors: [dynamicImportError],
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'import(`../${name}`)',
+      errors: [dynamicImportError],
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'import(name)',
+      errors: [dynamicImportError],
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
+    }),
+    test({
+      code: 'import(name())',
+      errors: [dynamicImportError],
+      parser: 'babel-eslint',
+      options: [{esmodule: true}],
     }),
   ],
 })