Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve modules if folder contains a package.json file #187

Merged
merged 4 commits into from
Oct 20, 2022

Commits on Sep 28, 2022

  1. fix: resolve modules if folder contains a package.json file

    getMappedPath only resolves to files that exist. This does not
    work when a TSConfig path alias resolves to a module folder
    containing built assets, and described by a package.json, e.g.
    foo/dist.
    
    If the tsconfig path is mapped to a folder, then getMappedPath
    returns undefined as the folder is not a file. However, in somes
    cases it is ok for this to resolve as the package.json contains
    a `typings` entry that references a .d.ts file, which is
    correctly handled by enhanced-resolve
    sanderson-ut committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    7d2642d View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2022

  1. fix: make filePaths platform agnostic

    Use `path.sep` as the file separator instead of `/` so that this
    works on both Windows and Unix.
    
    Rename input parameter from `path` to `modulePath` so that it
    doesn't override `node:path`
    sanderson-ut committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    fba2865 View commit details
    Browse the repository at this point in the history
  2. fix: use path.resolve instead of string interpolation

    Co-authored-by: JounQin <admin@1stg.me>
    sanderson-ut and JounQin committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    ea39e0b View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Create rare-plants-wait.md

    JounQin authored Oct 20, 2022
    Configuration menu
    Copy the full SHA
    27b4ce8 View commit details
    Browse the repository at this point in the history