refactor(user): update user interceptor #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ycdzj
commented
Nov 4, 2025
ycdzj
commented
- refactor(user): update user interceptor
- refactor(namespaces): remove uncategorized folder
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the automatic creation of an "uncategorized" folder when setting up a private root namespace and optimizes the user interceptor to extract user IDs earlier in the request lifecycle.
- Removed automatic creation of "uncategorized" subfolder in private root namespaces
- Refactored user ID extraction in the interceptor to occur before request handling rather than during response processing
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/namespaces/namespaces.service.ts | Removes the creation of an "uncategorized" folder within the private root resource |
| src/interceptor/user.interceptor.ts | Moves user ID extraction outside the tap operator to capture it earlier in the request lifecycle and consolidates span management in the finalize callback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.