Skip to content

Conversation

@ycdzj
Copy link
Contributor

@ycdzj ycdzj commented Oct 20, 2025

This reverts commit 4d95ee3.

Copilot AI review requested due to automatic review settings October 20, 2025 02:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the private root resource functionality when adding namespace members, implementing soft delete/restore patterns instead of permanent deletions. The change enables recovery of previously deleted private roots when re-adding users to namespaces.

Key Changes:

  • Added restoreResource and deleteResource methods to ResourcesService with transaction support
  • Refactored addMember to check for and restore existing deleted namespace members and their private roots
  • Extracted private root creation logic into a new createOrRestorePrivateRoot method

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/resources/resources.service.ts Added soft delete and restore methods for resources with transaction management
src/namespaces/namespaces.service.ts Refactored member addition to support restoring deleted private roots and consolidated creation logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@ycdzj ycdzj merged commit aea6633 into main Oct 20, 2025
4 checks passed
@ycdzj ycdzj deleted the refactor/namespaces branch October 20, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants