Merge pull request #223 from import-ai/fix/lint

build(lint): support test lint

Author: hewenguang

.github/workflows/ci.yaml

@@ -3,9 +3,9 @@ name: CI
 on:
   push:
     branches:
-      - "main"
+      - 'main'
     tags:
-      - "v*"
+      - 'v*'
   pull_request:
     branches:
       - 'main'
@@ -77,19 +77,46 @@ jobs:
           cache-from: type=gha
           cache-to: type=gha,mode=max
 
-  test:
+  lint:
     runs-on: ubuntu-latest
-    needs: [ runtime ]
-    container:
-      image: ghcr.io/import-ai/omnibox-backend-runtime:latest
-      credentials:
-        username: ${{ github.actor }}
-        password: ${{ secrets.GITHUB_TOKEN }}
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v4
 
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.17.1
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'pnpm'
+
+      - name: Install dependencies
+        run: pnpm install --frozen-lockfile
+
+      - name: Run lint
+        run: pnpm lint
+
+  test:
+    runs-on: ubuntu-latest
     steps:
       - name: Checkout
         uses: actions/checkout@v4
 
+      - name: Setup pnpm
+        uses: pnpm/action-setup@v4
+        with:
+          version: 10.17.1
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'pnpm'
+
       - name: Install dependencies
         run: pnpm install --frozen-lockfile
 
@@ -108,9 +135,7 @@ jobs:
       - name: Run tests
         run: pnpm test:e2e --coverage
         env:
-          OBB_POSTGRES_URL: postgres://omnibox:omnibox@postgres:5432/omnibox
-          OBB_MINIO_URL: http://username:password@minio:9000/omnibox
-          OBB_LOG_LEVELS: ""
+          OBB_LOG_LEVELS: ''
 
       - name: Print coverage report
         run: |
@@ -125,7 +150,7 @@ jobs:
 
   app:
     runs-on: ubuntu-latest
-    needs: [ test ]
+    needs: [runtime, test, lint]
     steps:
       - name: Checkout
         uses: actions/checkout@v4
@@ -172,7 +197,7 @@ jobs:
 
   webhook:
     runs-on: ubuntu-latest
-    needs: [ app ]
+    needs: [app]
     steps:
       - name: TEST push webhook
         if: github.event_name == 'push'

.husky/pre-commit

@@ -0,0 +1 @@
+pnpm lint:fix

Dockerfile

@@ -10,7 +10,7 @@ FROM ghcr.io/import-ai/omnibox-backend-runtime:latest
 
 WORKDIR /app
 COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
-RUN pnpm install --prod
+RUN HUSKY=0 pnpm install --prod
 COPY --from=builder /app/dist ./dist
 
 EXPOSE 3000

package.json

@@ -9,11 +9,13 @@
     "start:dev": "nest start --watch",
     "start:debug": "nest start --debug --watch",
     "start:prod": "node dist/main",
-    "lint": "eslint \"{src,apps,libs,test}/**/*.ts\" --fix",
+    "lint": "eslint \"{src,test}/**/*.ts\"",
+    "lint:fix": "eslint \"{src,test}/**/*.ts\" --fix",
     "test": "jest",
     "test:watch": "jest --watch",
     "test:debug": "node --inspect-brk -r tsconfig-paths/register -r ts-node/register node_modules/.bin/jest --runInBand",
-    "test:e2e": "jest --config jest.e2e-config.js --runInBand"
+    "test:e2e": "jest --config jest.e2e-config.js --runInBand",
+    "prepare": "husky || true"
   },
   "devDependencies": {
     "@eslint/eslintrc": "^3.3.1",
@@ -37,6 +39,7 @@
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-prettier": "^5.5.4",
     "globals": "^16.4.0",
+    "husky": "^9.1.7",
     "jest": "^29.7.0",
     "prettier": "^3.6.2",
     "source-map-support": "^0.5.21",

pnpm-lock.yaml

@@ -6,4 +6,4 @@ ENV PATH="$PNPM_HOME:$PATH"
 RUN corepack enable
 COPY package.json pnpm-lock.yaml pnpm-workspace.yaml ./
 RUN pnpm add -g pm2@6
-RUN pnpm install --prod
+RUN HUSKY=0 pnpm install --prod

runtime.Dockerfile

@@ -96,7 +96,7 @@ export class AuthService {
       lang?: string;
     },
   ) {
-    const payload: SignUpPayloadDto = await this.jwtVerify(token);
+    const payload: SignUpPayloadDto = this.jwtVerify(token);
     const account = await this.userService.findByEmail(payload.email);
     if (account) {
       const message = this.i18n.t('auth.errors.emailAlreadyExists');
@@ -227,7 +227,7 @@ export class AuthService {
   }
 
   async inviteConfirm(token: string): Promise<void> {
-    const payload: InvitePayloadDto = await this.jwtVerify(token);
+    const payload: InvitePayloadDto = this.jwtVerify(token);
     const user = await this.userService.find(payload.userId);
     await this.dataSource.transaction(async (manager) => {
       await this.handleUserInvitation(user.id, payload.invitation, manager);