Skip to content

Commit 8c8cc26

Browse files
Merge branch 'next' into next
2 parents 8b924e8 + afe7ed4 commit 8c8cc26

File tree

23 files changed

+122
-93
lines changed

23 files changed

+122
-93
lines changed

apps/api/package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,10 @@
1919
"test": "cross-env TZ=UTC NODE_ENV=test E2E_RUNNER=true mocha --timeout 10000 --require ts-node/register --exit src/**/**/*.spec.ts"
2020
},
2121
"dependencies": {
22-
"@impler/dal": "^0.24.1",
23-
"@impler/services": "^0.24.1",
24-
"@impler/shared": "^0.24.1",
22+
"@impler/client": "workspace:^",
23+
"@impler/dal": "workspace:^",
24+
"@impler/services": "workspace:^",
25+
"@impler/shared": "workspace:^",
2526
"@nestjs/common": "^9.1.2",
2627
"@nestjs/core": "^9.1.2",
2728
"@nestjs/jwt": "^10.0.1",

apps/api/src/app/column/commands/add-column.command.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { ColumnDelimiterEnum, ColumnTypesEnum, ValidatorTypesEnum } from '@impler/shared';
1+
import { ValidatorTypesEnum } from '@impler/client';
2+
import { ColumnDelimiterEnum, ColumnTypesEnum } from '@impler/shared';
23

34
export class ValidatorCommand {
45
validate: ValidatorTypesEnum;

apps/api/src/app/column/dtos/column-request.dto.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,12 @@ import {
1212
ValidateNested,
1313
} from 'class-validator';
1414
import { Type } from 'class-transformer';
15+
16+
import { ValidatorTypesEnum } from '@impler/client';
1517
import { IsValidRegex } from '@shared/framework/is-valid-regex.validator';
16-
import { IsNumberOrString } from '@shared/framework/number-or-string.validator';
17-
import { ColumnDelimiterEnum, ColumnTypesEnum, Defaults, ValidatorTypesEnum } from '@impler/shared';
1818
import { IsGreaterThan } from '@shared/framework/is-greator-than.validator';
19+
import { IsNumberOrString } from '@shared/framework/number-or-string.validator';
20+
import { ColumnDelimiterEnum, ColumnTypesEnum, Defaults } from '@impler/shared';
1921

2022
export class ValidatorDto {
2123
@ApiProperty({

apps/api/src/app/review/usecases/do-review/base-review.usecase.ts

Lines changed: 8 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -8,15 +8,9 @@ import * as customParseFormat from 'dayjs/plugin/customParseFormat';
88
import Ajv, { AnySchemaObject, ErrorObject, ValidateFunction } from 'ajv';
99

1010
import { ValidatorErrorMessages } from '@shared/types/review.types';
11+
import { ColumnTypesEnum, Defaults, ITemplateSchemaItem } from '@impler/shared';
1112
import { SManager, BATCH_LIMIT, MAIN_CODE, ExecuteIsolateResult } from '@shared/services/sandbox';
12-
import {
13-
ColumnTypesEnum,
14-
Defaults,
15-
ITemplateSchemaItem,
16-
LengthValidatorType,
17-
RangeValidatorType,
18-
ValidatorTypesEnum,
19-
} from '@impler/shared';
13+
import { ValidatorTypesEnum, LengthValidatorType, RangeValidatorType } from '@impler/client';
2014

2115
dayjs.extend(customParseFormat);
2216

@@ -193,10 +187,6 @@ export class BaseReview {
193187
let field: string;
194188

195189
return errors.reduce((obj, error) => {
196-
if (error.keyword === 'required') field = error.params.missingProperty;
197-
else [, field] = error.instancePath.split('/');
198-
199-
field = field.replace(/~1/g, '/');
200190
if (!!uniqueCombinations[error.keyword]) {
201191
uniqueCombinations[error.keyword].forEach((columnKey) => {
202192
obj[columnKey] = this.getMessage({
@@ -208,7 +198,11 @@ export class BaseReview {
208198
validatorErrorMessages,
209199
});
210200
});
211-
} else
201+
} else {
202+
if (error.keyword === 'required') field = error.params.missingProperty;
203+
else [, , field] = error.instancePath.split('/');
204+
205+
field = field.replace(/~1/g, '/');
212206
obj[field] = this.getMessage({
213207
error,
214208
data: error.data,
@@ -217,6 +211,7 @@ export class BaseReview {
217211
uniqueCombinations,
218212
validatorErrorMessages,
219213
});
214+
}
220215

221216
return obj;
222217
}, {});

apps/api/src/app/review/usecases/do-review/do-review.usecase.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ import { Writable } from 'stream';
33
import { Injectable, BadRequestException, InternalServerErrorException } from '@nestjs/common';
44

55
import { APIMessages } from '@shared/constants';
6-
import { EMAIL_SUBJECT, ValidatorTypesEnum } from '@impler/shared';
6+
import { EMAIL_SUBJECT } from '@impler/shared';
77
import { BaseReview } from './base-review.usecase';
8+
import { ValidatorTypesEnum } from '@impler/client';
89
import { BATCH_LIMIT } from '@shared/services/sandbox';
910
import { StorageService, PaymentAPIService, EmailService } from '@impler/services';
1011
import { ColumnTypesEnum, UploadStatusEnum, ITemplateSchemaItem, ColumnDelimiterEnum } from '@impler/shared';

apps/api/src/app/review/usecases/do-review/re-review-data.usecase.ts

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,14 @@ import { Writable } from 'stream';
33
import { ValidateFunction } from 'ajv';
44
import { Injectable, BadRequestException, InternalServerErrorException } from '@nestjs/common';
55

6+
import { ValidatorTypesEnum } from '@impler/client';
67
import { UploadRepository, ValidatorRepository, DalService, TemplateEntity } from '@impler/dal';
78
import {
8-
ColumnDelimiterEnum,
9+
EMAIL_SUBJECT,
910
ColumnTypesEnum,
10-
ITemplateSchemaItem,
1111
UploadStatusEnum,
12-
EMAIL_SUBJECT,
13-
ValidatorTypesEnum,
12+
ColumnDelimiterEnum,
13+
ITemplateSchemaItem,
1414
} from '@impler/shared';
1515

1616
import { APIMessages } from '@shared/constants';
@@ -69,7 +69,7 @@ export class DoReReview extends BaseReview {
6969
});
7070

7171
const columns = JSON.parse(uploadInfo.customSchema) as ITemplateSchemaItem[];
72-
const uniqueFieldsSet = new Set(...columns.filter((column) => column.isUnique).map((column) => column.key));
72+
const uniqueFieldsSet = new Set(columns.filter((column) => column.isUnique).map((column) => column.key));
7373
const multiSelectColumnHeadings: Record<string, string> = {};
7474
const validatorErrorMessages = {};
7575
(columns as ITemplateSchemaItem[]).forEach((column) => {
@@ -205,6 +205,7 @@ export class DoReReview extends BaseReview {
205205
validator,
206206
dateFormats,
207207
uniqueCombinations,
208+
validatorErrorMessages,
208209
multiSelectColumnHeadings,
209210
}: {
210211
uploadId: string;
@@ -231,6 +232,7 @@ export class DoReReview extends BaseReview {
231232
dateFormats,
232233
uniqueCombinations,
233234
index: record.index,
235+
validatorErrorMessages,
234236
passRecord: record.record,
235237
});
236238
response.totalRecords++;

apps/queue-manager/package.json

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
"lint:fix": "pnpm lint -- --fix"
1717
},
1818
"dependencies": {
19-
"@impler/dal": "^0.24.1",
20-
"@impler/services": "^0.24.1",
21-
"@impler/shared": "^0.24.1",
19+
"@impler/dal": "workspace:^",
20+
"@impler/services": "workspace:^",
21+
"@impler/shared": "workspace:^",
2222
"@sentry/node": "^7.112.2",
2323
"axios": "1.6.2",
2424
"dotenv": "^16.0.2",

apps/web/components/imports/forms/ColumnForm.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,8 @@ import {
1414
useMantineColorScheme,
1515
} from '@mantine/core';
1616

17-
import { ColumnTypesEnum, DEFAULT_VALUES, IColumn, ValidatorTypesEnum } from '@impler/shared';
17+
import { ValidatorTypesEnum } from '@impler/client';
18+
import { ColumnTypesEnum, DEFAULT_VALUES, IColumn } from '@impler/shared';
1819
import { colors, DELIMITERS, MODAL_KEYS, MODAL_TITLES, DOCUMENTATION_REFERENCE_LINKS } from '@config';
1920

2021
import { Button } from '@ui/button';
@@ -363,7 +364,7 @@ export function ColumnForm({ onSubmit, data, isLoading }: ColumnFormProps) {
363364
index={fields.findIndex((field) => field.validate === ValidatorTypesEnum.UNIQUE_WITH)}
364365
onCheckToggle={(status, index) => {
365366
if (status) {
366-
append({ validate: ValidatorTypesEnum.UNIQUE_WITH });
367+
append({ validate: ValidatorTypesEnum.UNIQUE_WITH, uniqueKey: '' });
367368
} else {
368369
remove(index);
369370
}

apps/web/components/imports/schema/ValidationsGroup.tsx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
import { ColumnTypesEnum, IColumn, ValidatorTypesEnum } from '@impler/shared';
21
import { Group } from '@mantine/core';
32
import { Badge } from '@ui/badge';
43
import { getColorForText } from '@shared/utils';
4+
import { ValidatorTypesEnum } from '@impler/client';
5+
import { ColumnTypesEnum, IColumn } from '@impler/shared';
56

67
interface IValidationsGroupProps {
78
item: IColumn;
@@ -54,7 +55,7 @@ export function ValidationsGroup({ item }: IValidationsGroupProps) {
5455
{item.validators?.map((validator) => {
5556
if (validator.validate === ValidatorTypesEnum.UNIQUE_WITH) {
5657
return (
57-
<Badge variant="filled" key={ValidatorTypesEnum.UNIQUE_WITH} color={getColorForText(validator.uniqueKey!)}>
58+
<Badge variant="filled" key={ValidatorTypesEnum.UNIQUE_WITH} color={getColorForText(validator.uniqueKey)}>
5859
Unique with: {validator.uniqueKey}
5960
</Badge>
6061
);

apps/web/design-system/auto-height-component/AutoHeightComponent.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export const AutoHeightComponent: React.FC<AutoHeightComponentProps> = ({ isVisi
3131
};
3232

3333
return (
34-
<Collapse in={isExpanded} onTransitionEnd={handleTransitionEnd}>
34+
<Collapse in={isExpanded} onTransitionEnd={handleTransitionEnd} w="100%">
3535
{isRendered && children}
3636
</Collapse>
3737
);

0 commit comments

Comments
 (0)