Skip to content

Commit 399b51c

Browse files
fred-wangCommit bot
authored andcommitted
Ozone: Improve sandboxing documentation
The Linux SUID sandbox is going to be removed [1]. Also, it may not necessary to disable it to run Ozone builds. Instead of repeating the command line parameter --disable-setuid-sandbox everywhere, the documentation is changed to point to the general Sandboxing page. BUG=None [1] https://bugs.chromium.org/p/chromium/issues/detail?id=312380 Review-Url: https://codereview.chromium.org/2480293011 Cr-Commit-Position: refs/heads/master@{#431226}
1 parent 0e33dad commit 399b51c

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

docs/ozone_overview.md

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ ninja -C out/OzoneChromeOS chrome
130130
Then to run for example the X11 platform:
131131

132132
``` shell
133-
./out/OzoneChromeOS/chrome --ozone-platform=x11 --disable-setuid-sandbox
133+
./out/OzoneChromeOS/chrome --ozone-platform=x11
134134
```
135135

136136
### Embedded
@@ -155,8 +155,7 @@ ninja -C out/OzoneEmbedded content_shell
155155
Then to run for example the headless platform:
156156

157157
``` shell
158-
./out/OzoneEmbedded/content_shell --disable-setuid-sandbox \
159-
--ozone-platform=headless \
158+
./out/OzoneEmbedded/content_shell --ozone-platform=headless \
160159
--ozone-dump-file=/tmp/
161160
```
162161

@@ -178,7 +177,6 @@ Then to run for example the X11 platform:
178177

179178
``` shell
180179
./out/OzoneLinuxDesktop/chrome --ozone-platform=x11 \
181-
--disable-setuid-sandbox \
182180
--mash
183181
```
184182

@@ -202,19 +200,19 @@ by default.
202200
## Running with Ozone
203201

204202
Specify the platform you want to use at runtime using the `--ozone-platform`
205-
flag. Disabling the setuid sandbox may be required during development.
206-
207-
For example, to run content_shell with the GBM platform:
203+
flag. For example, to run `content_shell` with the GBM platform:
208204

209205
``` shell
210-
content_shell --disable-setuid-sandbox --ozone-platform=gbm
206+
content_shell --ozone-platform=gbm
211207
```
212208

213209
Caveats:
214210

215211
* `content_shell` always runs at 800x600 resolution.
216212
* For the GBM platform, you may need to terminate your X server (or any other
217213
display server) prior to testing.
214+
* During development, you may need to configure
215+
[sandboxing](linux_sandboxing.md) or to disable it.
218216

219217
## Ozone Platforms
220218

@@ -228,8 +226,7 @@ by specifying `--ozone-dump-file=/path/to/output-directory` on the
228226
command line:
229227

230228
``` shell
231-
content_shell --disable-setuid-sandbox \
232-
--ozone-platform=headless \
229+
content_shell --ozone-platform=headless \
233230
--ozone-dump-file=/tmp/
234231
```
235232

@@ -270,8 +267,7 @@ following commands:
270267
gn args out/OzoneWayland --args="use_ozone=true enable_package_mash_services=true"
271268
ninja -C out/OzoneWayland chrome
272269
./out/OzoneWayland/chrome --ozone-platform=wayland \
273-
--mash \
274-
--disable-setuid-sandbox
270+
--mash
275271
```
276272

277273
### Caca
@@ -298,7 +294,7 @@ with the following commands:
298294
gn args out/OzoneCaca \
299295
--args="use_ozone=true ozone_platform_caca=true use_sysroot=false ozone_auto_platforms=false toolkit_views=false"
300296
ninja -C out/OzoneCaca content_shell
301-
./out/OzoneCaca/content_shell --disable-setuid-sandbox
297+
./out/OzoneCaca/content_shell
302298
```
303299

304300
Note: traditional TTYs are not the ideal browsing experience.<br/>

0 commit comments

Comments
 (0)