Skip to content

Stop printing a million instrumeting AArch64 loads/stores, as they're distracting #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: fw/instrument-llvm-ir
Choose a base branch
from

Conversation

kkysen
Copy link

@kkysen kkysen commented Mar 7, 2025

No description provided.

@kkysen kkysen requested a review from fw-immunant March 7, 2025 16:59
@fw-immunant
Copy link

fw-immunant commented Mar 7, 2025

We should have some straightforward way to distinguish our modified compiler from the stock one. Maybe gate this the printing under an environment variable?

EDIT: I mean that it might be best to just make these prints opt-in.

@kkysen
Copy link
Author

kkysen commented Mar 7, 2025

We should have some straightforward way to distinguish our modified compiler from the stock one. Maybe gate this under an environment variable?

What about just printing the message once the first time then?

@fw-immunant
Copy link

Also, the pattern we're following right now is basically to use branches as tags (which is admittedly ugly); currently CI on IA2 uses the fw/tweak-tagging branch, so future development should be atop that one. Additionally, IA2 CI currently caches clang based on the branch name, so updates to an existing branch won't be picked up until the cached CI artifacts are deleted. So we should either create a new branch or change IA2 CI to cache based on commit hash instead of branch name.

@fw-immunant
Copy link

We should have some straightforward way to distinguish our modified compiler from the stock one. Maybe gate this under an environment variable?

What about just printing the message once the first time then?

The advantage to printing for every function is that it's easy to see from logs if a given function was compiled with this compiler toolchain or not. That question is relevant in the presence of object files and static libs from the toolchain that also contribute code to the binaries we end up emitting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants