Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile on latest nightly #1098

Closed
theoparis opened this issue Jun 19, 2024 · 3 comments · Fixed by #1115
Closed

Fails to compile on latest nightly #1098

theoparis opened this issue Jun 19, 2024 · 3 comments · Fixed by #1115

Comments

@theoparis
Copy link

theoparis commented Jun 19, 2024

See time-rs/time#681, it seems like some dependencies need to be updated since it isn't used directly...

Adding the following to Cargo.toml in this repository seems to fix it for the time being.

[patch.crates-io]
time = { git = "https://github.com/time-rs/time" }

Update: I think the correct fix would actually be updating Cargo.lock and the time-macros crate.

@tommythorn
Copy link

With the risk of stating the obvious, this is also causing cargo install c2rust to fail.

@chrysn
Copy link
Contributor

chrysn commented Aug 28, 2024

Note that c2rust used to compile just fine also on stable Rust. So as theoparis mentioned in the update, unlocking time-rs-macros sounds like the way to go. We need time 0.3.35 to fix the build issue, which needs Rust 1.67, which is more recent than the currently locked nightly.

@kkysen
Copy link
Contributor

kkysen commented Aug 29, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants