-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Having a comma in a path added to external library breaks scanning #10699
Comments
This is not the common practice of naming folders and paths. I highly suggest moving away from this practice because, eventually, you will run into issues with different software. |
I also had a lot of trouble with spaces on my long paths. Ended up changing the paths, but this broke everything and had to install Immich from scratch again. |
I am having the same issue. Scanning is broken for paths containing a comma (","). This is clearly a bug in immich. On Linux a path can contain almost any character. Only the forward slash (/) and the NUL bytes is not possible. |
Yes, this clearly is a bug. Photo collections are often managed using multiple different tools and often enough it's easiest to "encode" album names as folders. As such they are often treated as plain unicode text, including spaces, commas, parentheses, ampersands, accented characters, asian glyphs, etc. None of this is unreasonable. Those names are not supposed to be 1970-style basic file names like in etc or usr (which I much appreciate for their easy handling BTW) It's not Windows either... ;-) |
Thanks for the report, I'll look into this |
Can confirm this bug. We do a brace expansion in the asGlob method of the storage repository. I'll have to figure out a way to solve this issue. Another way to trigger this bug is to have a brace like { or } in a path when having 2 or more import paths. |
The bug
When having multiple paths that have commas in them added to an external library breaks the library and it can't access any assets.
For example, I have an External library named test1:
The second example I have an External library named test2:
Third example I have an External library named test3:
For the record, I have been using commas in folders for a long time and it is not an OS issue.
The OS that Immich Server is running on
Docker 20.10.24, Docker Compose v2.21.0, Unraid 6.12.3 (kernal 6.1.38-Unraid )
Version of Immich Server
v1.106.2
Version of Immich Mobile App
N/A
Platform with the issue
Your docker-compose.yml content
I don't have one
Your .env content
I don't have one
Reproduction steps
Relevant log output
Additional information
No response
The text was updated successfully, but these errors were encountered: